Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve systrace marker in IntBufferBatchMountItem

Browse Source 
Summary:
It's useful to have more systrace markers that are all the same, so that they can all be aggregated and work underneath them aggregated across an entire trace. As it is, this marker gets treated as unique nearly every time which makes analysis harder.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D36533075

fbshipit-source-id: 925afa7db152eca1166891b41e7c6f6a511840af
This commit is contained in:
Joshua Gross
2022-05-23 16:54:58 -07:00
committed by Facebook GitHub Bot
parent 87d3ac3762
commit b36afe74ca
2 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountItemDispatcher.java
+3 -6
View File
@@ -206,8 +206,7 @@ public class MountItemDispatcher {
if (viewCommandMountItemsToDispatch != null) {
Systrace.beginSection(
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE,
"FabricUIManager::mountViews viewCommandMountItems to execute: "
+ viewCommandMountItemsToDispatch.size());
"FabricUIManager::mountViews viewCommandMountItems");
for (DispatchCommandMountItem command : viewCommandMountItemsToDispatch) {
if (ENABLE_FABRIC_LOGS) {
printMountItem(command, "dispatchMountItems: Executing viewCommandMountItem");
@@ -250,9 +249,7 @@ public class MountItemDispatcher {
if (preMountItemsToDispatch != null) {
Systrace.beginSection(
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE,
"FabricUIManager::mountViews preMountItems to execute: "
+ preMountItemsToDispatch.size());
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManager::mountViews preMountItems");
for (PreAllocateViewMountItem preMountItem : preMountItemsToDispatch) {
executeOrEnqueue(preMountItem);
@@ -264,7 +261,7 @@ public class MountItemDispatcher {
if (mountItemsToDispatch != null) {
Systrace.beginSection(
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE,
"FabricUIManager::mountViews mountItems to execute: " + mountItemsToDispatch.size());
"FabricUIManager::mountViews mountItems to execute");
long batchedExecutionStartTime = SystemClock.uptimeMillis();
ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/IntBufferBatchMountItem.java
+1 -10
View File
@@ -71,16 +71,7 @@ public class IntBufferBatchMountItem implements MountItem {
}
private void beginMarkers(String reason) {
Systrace.beginSection(
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE,
"FabricUIManager::"
+ reason
+ " - "
+ mIntBufferLen
+ " intBufSize "
+ " - "
+ mObjBufferLen
+ " objBufSize");
Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManager::" + reason);
if (mCommitNumber > 0) {
ReactMarker.logFabricMarker(