From b331229b06dde31ff92091a163cfabb030082925 Mon Sep 17 00:00:00 2001 From: Franco Meloni Date: Tue, 17 May 2022 04:02:19 -0700 Subject: [PATCH] Remove build_ios and use only test_ios (#33837) Summary: build_ios is a subset of test_ios. The Hermes cache takes 20-30 minutes to be downloaded and unarchived, that is the slowest part of both the jobs and that was duplicated. This means that if we remove build_ios we save a lot of time, and the CI is still covering the build and the testing of the code. ## Changelog [Internal] - Remove build_ios and use only test_ios Pull Request resolved: https://github.com/facebook/react-native/pull/33837 Test Plan: Checked on CircleCI Reviewed By: cipolleschi Differential Revision: D36437775 Pulled By: f-meloni fbshipit-source-id: 53adf77e3511963d2dbfadf26122fd70b0de1113 --- .circleci/config.yml | 64 -------------------------------------------- 1 file changed, 64 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8df857d2b2e..7fd350abee3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -399,64 +399,6 @@ jobs: - store_test_results: path: ./reports/junit - # ------------------------- - # JOBS: Build iOS - # ------------------------- - build_ios: - executor: reactnativeios - parameters: - use_frameworks: - type: boolean - default: false - steps: - - checkout - - setup_ruby - - run_yarn - - - run: | - cd packages/rn-tester - bundle check || bundle install - - - run: - name: Configure Environment Variables - command: | - echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV - source $BASH_ENV - - - run: - name: Configure Watchman - command: echo "{}" > .watchmanconfig - - - when: - condition: << parameters.use_frameworks >> - steps: - - run: - name: Set USE_FRAMEWORKS=1 - command: echo "export USE_FRAMEWORKS=1" >> $BASH_ENV - - - run: - name: Set USE_HERMES=1 - command: echo "export USE_HERMES=1" >> $BASH_ENV - - - run: - name: Set BUILD_HERMES_SOURCE=1 - command: echo "export BUILD_HERMES_SOURCE=1" >> $BASH_ENV - - - brew_install: - package: cmake - - - run: - name: Setup the CocoaPods environment - command: bundle exec pod setup - - - with_hermes_sdk_cache_span: - steps: - - with_rntester_pods_cache_span: - steps: - - run: - name: Generate RNTesterPods Workspace - command: cd packages/rn-tester && bundle exec pod install --verbose - # ------------------------- # JOBS: iOS Unit Tests # ------------------------- @@ -1296,15 +1238,9 @@ workflows: requires: - build_npm_package - test_ios_rntester - - build_ios - test_ios: run_unit_tests: true - requires: - - build_ios # DISABLED: USE_FRAMEWORKS=1 not supported by Flipper - # - build_ios: - # name: build_ios_frameworks - # use_frameworks: true # - test_ios: # name: test_ios_frameworks # use_frameworks: true