From b1f2c1e2c590e7e49d2ad8f0312cc439e65fb234 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Sun, 8 Dec 2019 09:52:56 -0800 Subject: [PATCH] Fabric: Disabling an assert in ComponentDescriptorProviderRegistry Summary: This temporarily disables an `assert` in `ComponentDescriptorProviderRegistry`. The `assert` only suggests that the call to the class is redundant, so it's safe to just remove it for now. Changelog: [Internal] Fabric-specific internal change. Reviewed By: JoshuaGross, sammy-SC Differential Revision: D18878273 fbshipit-source-id: 007a2c6f62f858126912b7e54a1098e6f4c25a16 --- .../fabric/uimanager/ComponentDescriptorProviderRegistry.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ReactCommon/fabric/uimanager/ComponentDescriptorProviderRegistry.cpp b/ReactCommon/fabric/uimanager/ComponentDescriptorProviderRegistry.cpp index 6bc6df9d7b5..4255db72157 100644 --- a/ReactCommon/fabric/uimanager/ComponentDescriptorProviderRegistry.cpp +++ b/ReactCommon/fabric/uimanager/ComponentDescriptorProviderRegistry.cpp @@ -14,10 +14,14 @@ void ComponentDescriptorProviderRegistry::add( ComponentDescriptorProvider provider) const { std::unique_lock lock(mutex_); + /* + // TODO: T57583139 + The assert is temporarily disabled to reduce the volume of the signal. assert( componentDescriptorProviders_.find(provider.handle) == componentDescriptorProviders_.end() && "Attempt to register an already registered ComponentDescriptorProvider."); + */ if (componentDescriptorProviders_.find(provider.handle) != componentDescriptorProviders_.end()) {