Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Implement data detection for android Text elements (#19216)

Browse Source 
Summary:
We want the ability to use Linkify on android text elements. This only adds this property to Text and not TextInput since there are some functional differences with how the types could be used between iOS and android - iOS allows one or many types while Linkify restricted us to providing only one option (using the masks).

Performance is affected ONLY FOR TEXT ELEMENTS USING THIS FEATURE since Linkify is searching for patterns.
Pull Request resolved: https://github.com/facebook/react-native/pull/19216

Differential Revision: D14621883

Pulled By: cpojer

fbshipit-source-id: cb692021d314140b9a92b29e23384afd7fd1b09e
This commit is contained in:
Kyle Pinkham
2019-03-26 12:31:30 -07:00
committed by Facebook Github Bot
parent 97c414ec8d
commit b1251d067a
6 changed files with 61 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java
+23
View File
@@ -9,6 +9,7 @@ package com.facebook.react.views.text;
import android.text.Spannable;
import android.text.TextUtils;
import android.text.util.Linkify;
import android.view.Gravity;
import android.view.View;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
@@ -160,4 +161,26 @@ public abstract class ReactTextAnchorViewManager<T extends View, C extends React
public void setDisabled(ReactTextView view, boolean disabled) {
view.setEnabled(!disabled);
}
@ReactProp(name = "dataDetectorType")
public void setDataDetectorType(ReactTextView view, @Nullable String type) {
switch (type) {
case "phoneNumber":
view.setLinkifyMask(Linkify.PHONE_NUMBERS);
break;
case "link":
view.setLinkifyMask(Linkify.WEB_URLS);
break;
case "email":
view.setLinkifyMask(Linkify.EMAIL_ADDRESSES);
break;
case "all":
view.setLinkifyMask(Linkify.ALL);
break;
case "none":
default:
view.setLinkifyMask(0);
break;
}
}
}
ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java
+14 -1
View File
@@ -14,7 +14,10 @@ import androidx.appcompat.widget.AppCompatTextView;
import android.text.Layout;
import android.text.Spannable;
import android.text.Spanned;
import android.text.Spannable;
import android.text.TextUtils;
import android.text.method.LinkMovementMethod;
import android.text.util.Linkify;
import android.view.Gravity;
import android.view.ViewGroup;
import com.facebook.common.logging.FLog;
@@ -35,6 +38,7 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
private int mTextAlign = Gravity.NO_GRAVITY;
private int mNumberOfLines = ViewDefaults.NUMBER_OF_LINES;
private TextUtils.TruncateAt mEllipsizeLocation = TextUtils.TruncateAt.END;
private int mLinkifyMaskType = 0;
private ReactViewBackgroundManager mReactBackgroundManager;
private Spannable mSpanned;
@@ -55,7 +59,12 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
if (getLayoutParams() == null) {
setLayoutParams(EMPTY_LAYOUT_PARAMS);
}
setText(update.getText());
Spannable spannable = update.getText();
if (mLinkifyMaskType > 0) {
Linkify.addLinks(spannable, mLinkifyMaskType);
setMovementMethod(LinkMovementMethod.getInstance());
}
setText(spannable);
setPadding(
(int) Math.floor(update.getPaddingLeft()),
(int) Math.floor(update.getPaddingTop()),
@@ -276,4 +285,8 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
public Spannable getSpanned() {
return mSpanned;
}
public void setLinkifyMask(int mask) {
mLinkifyMaskType = mask;
}
}