From af90bab9933da33828d563360949e4ee31c55f41 Mon Sep 17 00:00:00 2001 From: Christoph Pojer Date: Tue, 23 May 2017 06:45:10 -0700 Subject: [PATCH] Minor lint fixes Reviewed By: jeanlauliac Differential Revision: D5111517 fbshipit-source-id: 5cf8884334b881fb9a2b1b490972faf45c0c569b --- packager/src/Bundler/Bundle.js | 2 +- packager/src/Bundler/index.js | 4 ++-- packager/src/Bundler/util.js | 2 +- packager/src/JSTransformer/worker/minify.js | 5 +++-- packager/src/lib/GlobalTransformCache.js | 2 +- packager/src/node-haste/lib/AssetPaths.js | 2 +- packager/transformer.js | 2 +- 7 files changed, 10 insertions(+), 9 deletions(-) diff --git a/packager/src/Bundler/Bundle.js b/packager/src/Bundler/Bundle.js index 45d130e731f..fe3817a91c8 100644 --- a/packager/src/Bundler/Bundle.js +++ b/packager/src/Bundler/Bundle.js @@ -231,7 +231,7 @@ class Bundle extends BundleBase { result.sections.push({ offset: {line, column: 0}, - map: map, + map, }); line += module.code.split('\n').length; }); diff --git a/packager/src/Bundler/index.js b/packager/src/Bundler/index.js index b4e57d0432c..945d1c4e54a 100644 --- a/packager/src/Bundler/index.js +++ b/packager/src/Bundler/index.js @@ -198,7 +198,7 @@ class Bundler { } ); - const getTransformCacheKey = (options) => { + const getTransformCacheKey = options => { return transformCacheKey + getCacheKey(options); }; @@ -810,7 +810,7 @@ class Bundler { inlineRequires: transform.inlineRequires || false, platform, projectRoot: options.projectRoots[0], - } + }, }, preloadedModules: extraOptions.preloadedModules, ramGroups: extraOptions.ramGroups, diff --git a/packager/src/Bundler/util.js b/packager/src/Bundler/util.js index f64aba70719..1193ffccdbc 100644 --- a/packager/src/Bundler/util.js +++ b/packager/src/Bundler/util.js @@ -72,5 +72,5 @@ function filterObject(object, blacklist) { module.exports = { generateAssetCodeFileAst, generateAssetTransformResult, - isAssetTypeAnImage + isAssetTypeAnImage, }; diff --git a/packager/src/JSTransformer/worker/minify.js b/packager/src/JSTransformer/worker/minify.js index d6459ab465d..54f3c6384fb 100644 --- a/packager/src/JSTransformer/worker/minify.js +++ b/packager/src/JSTransformer/worker/minify.js @@ -18,14 +18,15 @@ const {UGLIFY_JS_OUTPUT_OPTIONS} = require('./JsMinification'); import type {MappingsMap} from '../../lib/SourceMap'; function minify(filename: string, inputCode: string, sourceMap: ?MappingsMap) { - let {code, map} = uglify.minify(inputCode, { + const result = uglify.minify(inputCode, { fromString: true, inSourceMap: sourceMap, outSourceMap: true, output: UGLIFY_JS_OUTPUT_OPTIONS, }); - map = JSON.parse(map); + const code = result.code; + const map = JSON.parse(result.map); map.sources = [filename]; return {code, map}; } diff --git a/packager/src/lib/GlobalTransformCache.js b/packager/src/lib/GlobalTransformCache.js index 29585beed82..11ff45919cc 100644 --- a/packager/src/lib/GlobalTransformCache.js +++ b/packager/src/lib/GlobalTransformCache.js @@ -386,7 +386,7 @@ class OptionsHasher { hashTransformOptions(hash: crypto$Hash, options: TransformOptionsStrict): crypto$Hash { const { generateSourceMaps, dev, hot, inlineRequires, platform, projectRoot, - ...unknowns, + ...unknowns } = options; const unknownKeys = Object.keys(unknowns); if (unknownKeys.length > 0) { diff --git a/packager/src/node-haste/lib/AssetPaths.js b/packager/src/node-haste/lib/AssetPaths.js index 3bac92c1b23..35083431ef5 100644 --- a/packager/src/node-haste/lib/AssetPaths.js +++ b/packager/src/node-haste/lib/AssetPaths.js @@ -61,7 +61,7 @@ function tryParse( assetName: path.join(dirPath, `${rootName}.${extension}`), name: rootName, platform, - resolution: resolution, + resolution, type: extension, }; } diff --git a/packager/transformer.js b/packager/transformer.js index 1aefd50e639..8adb5237610 100644 --- a/packager/transformer.js +++ b/packager/transformer.js @@ -134,7 +134,7 @@ function transform({filename, options, src}: Params) { ast: null, code: src, filename, - map: null + map: null, }; } else { const result = generate(ast, {