From aefb17421bdd02ad8e3050ad0ff46db2ff6bc2b4 Mon Sep 17 00:00:00 2001 From: Neil Dhar Date: Mon, 4 Apr 2022 15:47:29 -0700 Subject: [PATCH] Always enable debugger by default Summary: We currently enable the debugger by default on all platforms except Android. On Android, we then manually enable the debugger in debug builds. Instead, change it so the debugger is manually disabled in release builds, to simplify the setup. Changelog: [Internal] Reviewed By: jpporto Differential Revision: D35347444 fbshipit-source-id: a97bba0c65c61c211cf9e361e7091343a2c6416f --- ReactAndroid/hermes-engine/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/hermes-engine/build.gradle b/ReactAndroid/hermes-engine/build.gradle index 1628d972aff..e32c2ab0d3a 100644 --- a/ReactAndroid/hermes-engine/build.gradle +++ b/ReactAndroid/hermes-engine/build.gradle @@ -140,7 +140,6 @@ android { debug { externalNativeBuild { cmake { - arguments "-DHERMES_ENABLE_DEBUGGER=True" // JS developers aren't VM developers. // Therefore we're passing as build type Release, to provide a faster build. // This has the (unlucky) side effect of letting AGP call the build @@ -152,6 +151,7 @@ android { release { externalNativeBuild { cmake { + arguments "-DHERMES_ENABLE_DEBUGGER=False" arguments "-DCMAKE_BUILD_TYPE=MinSizeRel" } }