From ad43deca232b208956f44d46151571ba8064dd68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Thu, 3 Nov 2022 23:37:45 -0700 Subject: [PATCH] Remove unused saveFilesToRestore function Summary: The method that would restore these files was removed in https://github.com/facebook/react-native/pull/34846. The action performed by `saveFilesToRestore` is no longer necessary (thanks kelset for pointing this out). Changelog: [internal] Reviewed By: cortinico Differential Revision: D41003911 fbshipit-source-id: bbc057ac450e7f134c4664173291ca56c18f1b17 --- scripts/publish-npm.js | 3 --- scripts/release-utils.js | 22 ---------------------- 2 files changed, 25 deletions(-) diff --git a/scripts/publish-npm.js b/scripts/publish-npm.js index 4b9821b37c8..fea68bf374d 100755 --- a/scripts/publish-npm.js +++ b/scripts/publish-npm.js @@ -41,7 +41,6 @@ const { const { generateAndroidArtifacts, publishAndroidArtifactsToMaven, - saveFilesToRestore, } = require('./release-utils'); const fs = require('fs'); const os = require('os'); @@ -74,8 +73,6 @@ if (!argv.help) { echo(`The temp publishing folder is ${tmpPublishingFolder}`); } -saveFilesToRestore(tmpPublishingFolder); - // 34c034298dc9cad5a4553964a5a324450fda0385 const currentCommit = getCurrentCommit(); const shortCommit = currentCommit.slice(0, 9); diff --git a/scripts/release-utils.js b/scripts/release-utils.js index 5b018bdb03b..f2e8cbb6032 100644 --- a/scripts/release-utils.js +++ b/scripts/release-utils.js @@ -10,29 +10,8 @@ 'use strict'; const {exec, echo, exit, test, env, pushd, popd} = require('shelljs'); -const {saveFiles} = require('./scm-utils'); const {createHermesPrebuiltArtifactsTarball} = require('./hermes/hermes-utils'); -// TODO: we should probably remove this because of this? https://github.com/facebook/react-native/pull/34846 -function saveFilesToRestore(tmpPublishingFolder) { - const filesToSaveAndRestore = [ - 'template/Gemfile', - 'template/_ruby-version', - 'template/package.json', - '.ruby-version', - 'Gemfile.lock', - 'Gemfile', - 'package.json', - 'ReactAndroid/gradle.properties', - 'Libraries/Core/ReactNativeVersion.js', - 'React/Base/RCTVersion.m', - 'ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java', - 'ReactCommon/cxxreact/ReactNativeVersion.h', - ]; - - saveFiles(filesToSaveAndRestore, tmpPublishingFolder); -} - function generateAndroidArtifacts(releaseVersion, tmpPublishingFolder) { // -------- Generating Android Artifacts echo('Generating Android artifacts inside /tmp/maven-local'); @@ -136,5 +115,4 @@ module.exports = { generateAndroidArtifacts, generateiOSArtifacts, publishAndroidArtifactsToMaven, - saveFilesToRestore, };