From accc44eb7506cf5e54a4706e6752520f70d97a0d Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 15 May 2026 07:53:57 -0700 Subject: [PATCH] Fix Kotlin parameter name mismatches with supertypes (#56840) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56840 Fix Kotlin compiler warnings about overridden method parameter names not matching their supertypes. Rename `websocket` to `webSocket` in `WebSocketModule.onClosing` to match `WebSocketListener`, and rename `done` to `isLastChunk` in `MultipartStreamReaderTest` callbacks to match `CallCountTrackingChunkCallback`. Changelog: [Internal] Differential Revision: D105299024 fbshipit-source-id: fcf3718fbbfd342f598a05ddbe170a11480cce89 --- .../modules/websocket/WebSocketModule.kt | 4 ++-- .../devsupport/MultipartStreamReaderTest.kt | 20 +++++++++++++------ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.kt index c6abfe36127..ab9a036d59e 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.kt @@ -154,8 +154,8 @@ public class WebSocketModule(context: ReactApplicationContext) : sendEvent("websocketOpen", params) } - override fun onClosing(websocket: WebSocket, code: Int, reason: String) { - websocket.close(code, reason) + override fun onClosing(webSocket: WebSocket, code: Int, reason: String) { + webSocket.close(code, reason) } override fun onClosed(webSocket: WebSocket, code: Int, reason: String) { diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt index c0753a45ca0..de2655d8722 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt @@ -34,10 +34,14 @@ class MultipartStreamReaderTest { val callback: CallCountTrackingChunkCallback = object : CallCountTrackingChunkCallback() { - override fun onChunkComplete(headers: Map, body: Buffer, done: Boolean) { - super.onChunkComplete(headers, body, done) + override fun onChunkComplete( + headers: Map, + body: Buffer, + isLastChunk: Boolean, + ) { + super.onChunkComplete(headers, body, isLastChunk) - assertThat(done).isTrue + assertThat(isLastChunk).isTrue assertThat(headers["Content-Type"]).isEqualTo("application/json; charset=utf-8") assertThat(body.readUtf8()).isEqualTo("{}") } @@ -70,10 +74,14 @@ class MultipartStreamReaderTest { val callback: CallCountTrackingChunkCallback = object : CallCountTrackingChunkCallback() { - override fun onChunkComplete(headers: Map, body: Buffer, done: Boolean) { - super.onChunkComplete(headers, body, done) + override fun onChunkComplete( + headers: Map, + body: Buffer, + isLastChunk: Boolean, + ) { + super.onChunkComplete(headers, body, isLastChunk) - assertThat(done).isEqualTo(callCount == 3) + assertThat(isLastChunk).isEqualTo(callCount == 3) assertThat(body.readUtf8()).isEqualTo("$callCount") } }