From acb88d477e325fd0062d025ce2afe310bdf22099 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Wed, 4 Oct 2023 05:49:39 -0700 Subject: [PATCH] Makes the Jobs required for Hermes to run in tagged build while releasing (#39806) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39806 Same issue of the previous fix: jobs do not run by default on tagged build. I forgot to add the filter parameter in the jobs that build the slices for Hermes and packages it and therefore the build failed. I added those filters, so now we should be able to release RC.1. What puzzles me is how it is possible that the publish-npm jobs even started, given that it was set up to depends on a job called build_hermes_macos which was not executed in the pipeline. 🤔 https://pxl.cl/3w2rr ## Changelog: [Internal] - Make sure that the Hermes jobs starts when releasing Reviewed By: dmytrorykun Differential Revision: D49906898 fbshipit-source-id: ebbceb6cbc4dcd2ac22445610da1c52000c8ae2a --- .circleci/configurations/workflows.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.circleci/configurations/workflows.yml b/.circleci/configurations/workflows.yml index 4b346cb78fa..be128b7d0af 100644 --- a/.circleci/configurations/workflows.yml +++ b/.circleci/configurations/workflows.yml @@ -43,6 +43,7 @@ workflows: requires: - prepare_hermes_workspace - build_apple_slices_hermes: + filters: *only_release_tags requires: - build_hermesc_apple matrix: @@ -54,6 +55,7 @@ workflows: requires: - prepare_hermes_workspace - build_hermes_macos: + filters: *only_release_tags requires: - build_apple_slices_hermes matrix: