From ac1cdaa71620d5bb4860237cafb108f6aeae9aef Mon Sep 17 00:00:00 2001 From: Ruslan Shestopalyuk Date: Tue, 21 Nov 2023 10:51:40 -0800 Subject: [PATCH] Make ImageManager implementation overridable (#41582) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/41582 # Changelog: This will allow to have custom `ImageManager` implementations on new platforms. Reviewed By: christophpurrer Differential Revision: D51495143 fbshipit-source-id: bbd03bdad1b87fd53e70a886f1fdc74f371987c8 --- .../react/renderer/imagemanager/ImageManager.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h b/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h index 600e4b3d991..128be698388 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h @@ -21,15 +21,17 @@ class ImageManager; using SharedImageManager = std::shared_ptr; /* - * Cross platform facade for iOS-specific RCTImageManager. + * Cross platform facade for image management (e.g. iOS-specific + * RCTImageManager) */ class ImageManager { public: ImageManager(const ContextContainer::Shared& contextContainer); - ~ImageManager(); + virtual ~ImageManager(); - ImageRequest requestImage(const ImageSource& imageSource, SurfaceId surfaceId) - const; + virtual ImageRequest requestImage( + const ImageSource& imageSource, + SurfaceId surfaceId) const; private: void* self_{};