diff --git a/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.cpp b/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.cpp index b3f1dbdf2c4..94da446666f 100644 --- a/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.cpp +++ b/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.cpp @@ -44,7 +44,12 @@ void TurboModuleBinding::install( const jsi::Value &thisVal, const jsi::Value *args, size_t count) { - return binding.getModule(rt, thisVal, args, count); + if (count < 1) { + throw std::invalid_argument( + "__turboModuleProxy must be called with at least 1 argument"); + } + std::string moduleName = args[0].getString(rt).utf8(rt); + return binding.getModule(rt, moduleName); })); } @@ -54,15 +59,7 @@ TurboModuleBinding::~TurboModuleBinding() { jsi::Value TurboModuleBinding::getModule( jsi::Runtime &runtime, - const jsi::Value &thisVal, - const jsi::Value *args, - size_t count) const { - if (count < 1) { - throw std::invalid_argument( - "__turboModuleProxy must be called with at least 1 argument"); - } - std::string moduleName = args[0].getString(runtime).utf8(runtime); - + const std::string &moduleName) const { std::shared_ptr module; { SystraceSection s( diff --git a/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.h b/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.h index 27da12b506f..dcf8eaaa2d8 100644 --- a/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.h +++ b/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.h @@ -45,11 +45,8 @@ class TurboModuleBinding { * A lookup function exposed to JS to get an instance of a TurboModule * for the given name. */ - jsi::Value getModule( - jsi::Runtime &runtime, - const jsi::Value &thisVal, - const jsi::Value *args, - size_t count) const; + jsi::Value getModule(jsi::Runtime &runtime, const std::string &moduleName) + const; TurboModuleProviderFunctionType moduleProvider_; TurboModuleBindingMode bindingMode_;