From aa0670b0ae0b9838f6ed13c0f231eec76334fe67 Mon Sep 17 00:00:00 2001 From: zhongwuzw Date: Fri, 15 Mar 2024 06:15:44 -0700 Subject: [PATCH] iOS: Change image source url encode ascii to utf8 (#43502) Summary: We should use utf8 to cover more characters. ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Change image source url encode ascii to utf8 Pull Request resolved: https://github.com/facebook/react-native/pull/43502 Test Plan: Fixes https://github.com/facebook/react-native/issues/43462 Reviewed By: rshest Differential Revision: D54944653 Pulled By: cortinico fbshipit-source-id: 0bbd3d46c8e5c04ceffe7e0ebae46dc2ce9507df --- .../renderer/imagemanager/RCTImagePrimitivesConversions.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h index 0aa6a75b92e..6d63cdad1e6 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h @@ -48,10 +48,10 @@ inline static NSURL *NSURLFromImageSource(const facebook::react::ImageSource &im { // `NSURL` has a history of crashing with bad input, so let's be safe. @try { - NSString *urlString = [NSString stringWithCString:imageSource.uri.c_str() encoding:NSASCIIStringEncoding]; + NSString *urlString = [NSString stringWithUTF8String:imageSource.uri.c_str()]; if (!imageSource.bundle.empty()) { - NSString *bundle = [NSString stringWithCString:imageSource.bundle.c_str() encoding:NSASCIIStringEncoding]; + NSString *bundle = [NSString stringWithUTF8String:imageSource.bundle.c_str()]; urlString = [NSString stringWithFormat:@"%@.bundle/%@", bundle, urlString]; }