mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Remove dead JSIndexedRAMBundle from cxxreact
Summary: X-link: https://github.com/facebook/react-native/pull/57133 `JSIndexedRAMBundle` was a deprecated legacy-architecture class (annotated `[[deprecated("This API will be removed along with the legacy architecture.")]]` and guarded by `#ifndef RCT_REMOVE_LEGACY_ARCH`) for parsing indexed RAM bundles. It was only ever instantiated by `Instance::loadRAMBundleFromString` and `Instance::loadRAMBundleFromFile`, and those two `Instance` methods have no callers anywhere in fbsource: the old Android entry point `CatalystInstanceImpl` that used to call them has been deleted, and the new architecture (`ReactInstance` / bridgeless) routes `loadScriptFromFile` through `loadJSBundleFromFile` in the new runtime, never touching the legacy `Instance`. The only remaining user was its own unit test. This removes `JSIndexedRAMBundle` and the two dead `Instance` RAM-bundle loaders that referenced it: - Delete `JSIndexedRAMBundle.cpp`, `JSIndexedRAMBundle.h`, and `JSIndexedRAMBundleTest.cpp`. - Remove `loadRAMBundleFromString` / `loadRAMBundleFromFile` from `Instance.cpp` / `Instance.h` and drop the now-unused include. - Drop `JSIndexedRAMBundle.h` from `CXXREACT_PUBLIC_HEADERS` in `cxxreact/BUCK`. - Update the committed C++ API snapshots accordingly. The broader legacy RAM-bundle machinery (`RAMBundleRegistry`, `JSModulesUnbundle`, `Instance::loadRAMBundle`, `JSIExecutor::setBundleRegistry`) is left in place; it belongs to the same `RCT_REMOVE_LEGACY_ARCH` legacy bridge and can be removed as a follow-up. Changelog: [Internal] Reviewed By: javache, mdvacca Differential Revision: D108001933 fbshipit-source-id: 4b0f12258e8caff1991847a4bb211e94fbecefa8
This commit is contained in:
1 parent
20931fe975
commit
a8d16b623e
11 files changed
-380
No files matched your search
@@ -2727,8 +2727,6 @@ class facebook::react::Instance {
|
||||
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
|
||||
public void initializeRuntime();
|
||||
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
|
||||
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
|
||||
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
|
||||
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
|
||||
@@ -3004,14 +3002,6 @@ class facebook::react::JSINativeModules {
|
||||
public void reset();
|
||||
}
|
||||
|
||||
class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
|
||||
public JSIndexedRAMBundle(const char* sourcePath);
|
||||
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
|
||||
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
|
||||
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
|
||||
}
|
||||
|
||||
class facebook::react::JSModulesUnbundle {
|
||||
public JSModulesUnbundle();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
|
||||
|
||||
@@ -2724,8 +2724,6 @@ class facebook::react::Instance {
|
||||
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
|
||||
public void initializeRuntime();
|
||||
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
|
||||
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
|
||||
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
|
||||
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
|
||||
@@ -3001,14 +2999,6 @@ class facebook::react::JSINativeModules {
|
||||
public void reset();
|
||||
}
|
||||
|
||||
class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
|
||||
public JSIndexedRAMBundle(const char* sourcePath);
|
||||
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
|
||||
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
|
||||
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
|
||||
}
|
||||
|
||||
class facebook::react::JSModulesUnbundle {
|
||||
public JSModulesUnbundle();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
|
||||
|
||||
@@ -5134,8 +5134,6 @@ class facebook::react::Instance {
|
||||
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
|
||||
public void initializeRuntime();
|
||||
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
|
||||
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
|
||||
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
|
||||
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
|
||||
@@ -5281,14 +5279,6 @@ class facebook::react::JSIRuntimeHolder : public facebook::react::JSRuntime {
|
||||
public virtual facebook::jsi::Runtime& getRuntime() noexcept override;
|
||||
}
|
||||
|
||||
class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
|
||||
public JSIndexedRAMBundle(const char* sourcePath);
|
||||
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
|
||||
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
|
||||
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
|
||||
}
|
||||
|
||||
class facebook::react::JSModulesUnbundle {
|
||||
public JSModulesUnbundle();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
|
||||
|
||||
@@ -5131,8 +5131,6 @@ class facebook::react::Instance {
|
||||
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
|
||||
public void initializeRuntime();
|
||||
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
|
||||
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
|
||||
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
|
||||
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
|
||||
@@ -5278,14 +5276,6 @@ class facebook::react::JSIRuntimeHolder : public facebook::react::JSRuntime {
|
||||
public virtual facebook::jsi::Runtime& getRuntime() noexcept override;
|
||||
}
|
||||
|
||||
class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
|
||||
public JSIndexedRAMBundle(const char* sourcePath);
|
||||
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
|
||||
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
|
||||
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
|
||||
}
|
||||
|
||||
class facebook::react::JSModulesUnbundle {
|
||||
public JSModulesUnbundle();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
|
||||
|
||||
@@ -1846,8 +1846,6 @@ class facebook::react::Instance {
|
||||
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
|
||||
public void initializeRuntime();
|
||||
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
|
||||
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
|
||||
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
|
||||
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
|
||||
@@ -1988,14 +1986,6 @@ class facebook::react::JSINativeModules {
|
||||
public void reset();
|
||||
}
|
||||
|
||||
class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
|
||||
public JSIndexedRAMBundle(const char* sourcePath);
|
||||
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
|
||||
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
|
||||
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
|
||||
}
|
||||
|
||||
class facebook::react::JSModulesUnbundle {
|
||||
public JSModulesUnbundle();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
|
||||
|
||||
@@ -1843,8 +1843,6 @@ class facebook::react::Instance {
|
||||
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
|
||||
public void initializeRuntime();
|
||||
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
|
||||
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
|
||||
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
|
||||
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
|
||||
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
|
||||
@@ -1985,14 +1983,6 @@ class facebook::react::JSINativeModules {
|
||||
public void reset();
|
||||
}
|
||||
|
||||
class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
|
||||
public JSIndexedRAMBundle(const char* sourcePath);
|
||||
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
|
||||
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
|
||||
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
|
||||
}
|
||||
|
||||
class facebook::react::JSModulesUnbundle {
|
||||
public JSModulesUnbundle();
|
||||
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
|
||||
|
||||
Reference in new issue
Block a user