From a6f5e5adebed3d9da411f99548e2d8ce96636e16 Mon Sep 17 00:00:00 2001
From: Zeya Peng <zeyap@meta.com>
Date: Tue, 16 Jul 2024 16:35:13 -0700
Subject: [PATCH] Fix react/renderer ColorTest (#45485)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45485

## Changelog:

the new functions I introduced in https://github.com/facebook/react-native/pull/45365 to read color channel value, like `alphaFromColor`, will return float between 0~255 on iOS and 8bit unsigned ints on other platforms, because of different platform implementation. However that way we cannot assume consistent return value across platforms, which kind of contradicts with RN's cross platform design.

so here I make `alphaFromColor` in Color.h (the cross platform method) to always return uint8_t, while still allow `alphaFromHostPlatformColor` to return different result

[Internal] [Fixed] -

Reviewed By: christophpurrer

Differential Revision: D59826142

fbshipit-source-id: 4401918be29980474bdc8601443ae33155710f22
---
 .../react/renderer/graphics/Color.cpp            | 16 ++++++++--------
 .../ReactCommon/react/renderer/graphics/Color.h  |  8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/packages/react-native/ReactCommon/react/renderer/graphics/Color.cpp b/packages/react-native/ReactCommon/react/renderer/graphics/Color.cpp
index b1e9c9cc791..94c9ad2c9b2 100644
--- a/packages/react-native/ReactCommon/react/renderer/graphics/Color.cpp
+++ b/packages/react-native/ReactCommon/react/renderer/graphics/Color.cpp
@@ -28,23 +28,23 @@ ColorComponents colorComponentsFromColor(SharedColor sharedColor) {
 }
 
 // Read alpha channel in [0, 255] range
-float alphaFromColor(SharedColor color) {
-  return alphaFromHostPlatformColor(*color);
+uint8_t alphaFromColor(SharedColor color) {
+  return static_cast<uint8_t>(std::round(alphaFromHostPlatformColor(*color)));
 }
 
 // Read red channel in [0, 255] range
-float redFromColor(SharedColor color) {
-  return redFromHostPlatformColor(*color);
+uint8_t redFromColor(SharedColor color) {
+  return static_cast<uint8_t>(std::round(redFromHostPlatformColor(*color)));
 }
 
 // Read green channel in [0, 255] range
-float greenFromColor(SharedColor color) {
-  return greenFromHostPlatformColor(*color);
+uint8_t greenFromColor(SharedColor color) {
+  return static_cast<uint8_t>(std::round(greenFromHostPlatformColor(*color)));
 }
 
 // Read blue channel in [0, 255] range
-float blueFromColor(SharedColor color) {
-  return blueFromHostPlatformColor(*color);
+uint8_t blueFromColor(SharedColor color) {
+  return static_cast<uint8_t>(std::round(blueFromHostPlatformColor(*color)));
 }
 
 // Create Color with RGBA values in [0, 255] range
diff --git a/packages/react-native/ReactCommon/react/renderer/graphics/Color.h b/packages/react-native/ReactCommon/react/renderer/graphics/Color.h
index c63dacae164..3ef5627fd57 100644
--- a/packages/react-native/ReactCommon/react/renderer/graphics/Color.h
+++ b/packages/react-native/ReactCommon/react/renderer/graphics/Color.h
@@ -57,10 +57,10 @@ bool isColorMeaningful(const SharedColor& color) noexcept;
 SharedColor colorFromComponents(ColorComponents components);
 ColorComponents colorComponentsFromColor(SharedColor color);
 
-float alphaFromColor(SharedColor color);
-float redFromColor(SharedColor color);
-float greenFromColor(SharedColor color);
-float blueFromColor(SharedColor color);
+uint8_t alphaFromColor(SharedColor color);
+uint8_t redFromColor(SharedColor color);
+uint8_t greenFromColor(SharedColor color);
+uint8_t blueFromColor(SharedColor color);
 SharedColor colorFromRGBA(uint8_t r, uint8_t g, uint8_t b, uint8_t a);
 
 SharedColor clearColor();