From a6b862d427232b5dc94cb4c0c69c3de680b8aa72 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 17 Jun 2024 06:51:24 -0700 Subject: [PATCH] clean up systrace for systrace View preallocation (#44956) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44956 changelog: [internal] do not show systrace logs for flattened views. Reviewed By: rubennorte Differential Revision: D58587946 fbshipit-source-id: 6ef12feb352b9c79db6b91767c2d77906bba9cdc --- .../ReactAndroid/src/main/jni/react/fabric/Binding.cpp | 4 ---- .../src/main/jni/react/fabric/FabricMountingManager.cpp | 6 ++++++ .../ReactCommon/react/renderer/scheduler/Scheduler.cpp | 2 -- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp index 280ae463d33..b1d443cc265 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp @@ -509,10 +509,6 @@ void Binding::schedulerShouldRenderTransactions( void Binding::schedulerDidRequestPreliminaryViewAllocation( const ShadowNode& shadowNode) { - if (!shadowNode.getTraits().check(ShadowNodeTraits::Trait::FormsView)) { - return; - } - auto mountingManager = getMountingManager("preallocateView"); if (!mountingManager) { return; diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp index ca193764065..ab08744f65e 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp @@ -786,6 +786,12 @@ void FabricMountingManager::executeMount( void FabricMountingManager::preallocateShadowView( const ShadowNode& shadowNode) { + if (!shadowNode.getTraits().check(ShadowNodeTraits::Trait::FormsView)) { + return; + } + + SystraceSection section("FabricMountingManager::preallocateShadowView"); + { std::lock_guard lock(allocatedViewsMutex_); auto allocatedViewsIterator = diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp index a806d1e9f07..8469db75820 100644 --- a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp +++ b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp @@ -310,8 +310,6 @@ void Scheduler::uiManagerDidFinishTransaction( } void Scheduler::uiManagerDidCreateShadowNode(const ShadowNode& shadowNode) { - SystraceSection s("Scheduler::uiManagerDidCreateShadowNode"); - if (delegate_ != nullptr) { delegate_->schedulerDidRequestPreliminaryViewAllocation(shadowNode); }