From a6a34ba1d1bfc61b5c30a2dd5c9bd241637c8009 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Tue, 3 Dec 2019 15:35:20 -0800 Subject: [PATCH] Add codegen specs as dependencies of NativeModules Summary: ## Step 1 I'm going to make every Java NativeModule type-safe and TurboModule-compatible. The first step is to make sure that every type-unsafe NativeModule has a dependency on its spec's codegen target. ## Input Module -> owner(Module): P123320255 Module -> name(Module): P123320256 Module -> owner(spec(name(Module))): P123320257 ### Excluded NativeModules NativeModules without Specs: P123320644 Java only NativeModules: P123320645 Changelog: [Internal] - Add buck dependencies for NativeModule specs Reviewed By: mdvacca Differential Revision: D18781629 fbshipit-source-id: 89f39017b8224355d9d7b43bf6c162b0957760ee --- .../FBReactNativeSpec-generated.mm | 33 +++++++ .../FBReactNativeSpec/FBReactNativeSpec.h | 92 +++++++++++++++++++ .../specs/NativeTimePickerAndroidSpec.java | 30 ++++++ .../java/com/facebook/react/animated/BUCK | 1 + .../java/com/facebook/react/devsupport/BUCK | 1 + .../react/modules/accessibilityinfo/BUCK | 1 + .../facebook/react/modules/appearance/BUCK | 1 + .../com/facebook/react/modules/appstate/BUCK | 1 + .../java/com/facebook/react/modules/blob/BUCK | 3 + .../com/facebook/react/modules/camera/BUCK | 3 + .../java/com/facebook/react/modules/core/BUCK | 3 + .../facebook/react/modules/datepicker/BUCK | 1 + .../facebook/react/modules/deviceinfo/BUCK | 3 + .../com/facebook/react/modules/dialog/BUCK | 1 + .../com/facebook/react/modules/intent/BUCK | 1 + .../com/facebook/react/modules/network/BUCK | 1 + .../facebook/react/modules/permissions/BUCK | 1 + .../com/facebook/react/modules/share/BUCK | 1 + .../com/facebook/react/modules/sound/BUCK | 1 + .../com/facebook/react/modules/statusbar/BUCK | 1 + .../com/facebook/react/modules/storage/BUCK | 1 + .../facebook/react/modules/systeminfo/BUCK | 2 + .../facebook/react/modules/timepicker/BUCK | 1 + .../com/facebook/react/modules/toast/BUCK | 1 + .../com/facebook/react/modules/vibration/BUCK | 1 + 25 files changed, 186 insertions(+) create mode 100644 ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeTimePickerAndroidSpec.java diff --git a/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec-generated.mm b/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec-generated.mm index a0c033417ac..087773c2434 100644 --- a/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec-generated.mm +++ b/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec-generated.mm @@ -2350,6 +2350,39 @@ namespace facebook { } // namespace react } // namespace facebook +@implementation RCTCxxConvert (NativeTimePickerAndroid_TimePickerOptions) ++ (RCTManagedPointer *)JS_NativeTimePickerAndroid_TimePickerOptions:(id)json +{ + return facebook::react::managedPointer(json); +} +@end +namespace facebook { + namespace react { + + + static facebook::jsi::Value __hostFunction_NativeTimePickerAndroidSpecJSI_open(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) { + return static_cast(turboModule).invokeObjCMethod(rt, PromiseKind, "open", @selector(open:resolve:reject:), args, count); + } + + + NativeTimePickerAndroidSpecJSI::NativeTimePickerAndroidSpecJSI(id instance, std::shared_ptr jsInvoker) + : ObjCTurboModule("TimePickerAndroid", instance, jsInvoker) { + + methodMap_["open"] = MethodMetadata {1, __hostFunction_NativeTimePickerAndroidSpecJSI_open}; + + setMethodArgConversionSelector(@"open", 0, @"JS_NativeTimePickerAndroid_TimePickerOptions:"); + + + } + + } // namespace react +} // namespace facebook +@implementation RCTCxxConvert (NativeTimePickerAndroid_TimePickerResult) ++ (RCTManagedPointer *)JS_NativeTimePickerAndroid_TimePickerResult:(id)json +{ + return facebook::react::managedPointer(json); +} +@end namespace facebook { namespace react { diff --git a/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h b/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h index 637161e82a7..0d39cefcab4 100644 --- a/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h +++ b/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h @@ -2519,6 +2519,63 @@ namespace facebook { }; } // namespace react } // namespace facebook + +namespace JS { + namespace NativeTimePickerAndroid { + struct TimePickerOptions { + folly::Optional hour() const; + folly::Optional minute() const; + folly::Optional is24Hour() const; + NSString *mode() const; + + TimePickerOptions(NSDictionary *const v) : _v(v) {} + private: + NSDictionary *_v; + }; + } +} + +@interface RCTCxxConvert (NativeTimePickerAndroid_TimePickerOptions) ++ (RCTManagedPointer *)JS_NativeTimePickerAndroid_TimePickerOptions:(id)json; +@end +@protocol NativeTimePickerAndroidSpec + +- (void)open:(JS::NativeTimePickerAndroid::TimePickerOptions &)options + resolve:(RCTPromiseResolveBlock)resolve + reject:(RCTPromiseRejectBlock)reject; + +@end +namespace facebook { + namespace react { + /** + * ObjC++ class for module 'TimePickerAndroid' + */ + + class JSI_EXPORT NativeTimePickerAndroidSpecJSI : public ObjCTurboModule { + public: + NativeTimePickerAndroidSpecJSI(id instance, std::shared_ptr jsInvoker); + + }; + } // namespace react +} // namespace facebook + +namespace JS { + namespace NativeTimePickerAndroid { + struct TimePickerResult { + NSString *action() const; + double hour() const; + double minute() const; + + TimePickerResult(NSDictionary *const v) : _v(v) {} + private: + NSDictionary *_v; + }; + } +} + +@interface RCTCxxConvert (NativeTimePickerAndroid_TimePickerResult) ++ (RCTManagedPointer *)JS_NativeTimePickerAndroid_TimePickerResult:(id)json; +@end @protocol NativeTimingSpec - (void)createTimer:(double)callbackID @@ -3730,6 +3787,41 @@ inline JS::NativeStatusBarManagerIOS::Constants::Builder::Builder(const Input i) inline JS::NativeStatusBarManagerIOS::Constants::Builder::Builder(Constants i) : _factory(^{ return i.unsafeRawValue(); }) {} +inline folly::Optional JS::NativeTimePickerAndroid::TimePickerOptions::hour() const +{ + id const p = _v[@"hour"]; + return RCTBridgingToOptionalDouble(p); +} +inline folly::Optional JS::NativeTimePickerAndroid::TimePickerOptions::minute() const +{ + id const p = _v[@"minute"]; + return RCTBridgingToOptionalDouble(p); +} +inline folly::Optional JS::NativeTimePickerAndroid::TimePickerOptions::is24Hour() const +{ + id const p = _v[@"is24Hour"]; + return RCTBridgingToOptionalBool(p); +} +inline NSString *JS::NativeTimePickerAndroid::TimePickerOptions::mode() const +{ + id const p = _v[@"mode"]; + return RCTBridgingToString(p); +} +inline NSString *JS::NativeTimePickerAndroid::TimePickerResult::action() const +{ + id const p = _v[@"action"]; + return RCTBridgingToString(p); +} +inline double JS::NativeTimePickerAndroid::TimePickerResult::hour() const +{ + id const p = _v[@"hour"]; + return RCTBridgingToDouble(p); +} +inline double JS::NativeTimePickerAndroid::TimePickerResult::minute() const +{ + id const p = _v[@"minute"]; + return RCTBridgingToDouble(p); +} inline JS::NativeToastAndroid::Constants::Builder::Builder(const Input i) : _factory(^{ NSMutableDictionary *d = [NSMutableDictionary new]; auto SHORT = i.SHORT.get(); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeTimePickerAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeTimePickerAndroidSpec.java new file mode 100644 index 00000000000..e9707f4f3b3 --- /dev/null +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeTimePickerAndroidSpec.java @@ -0,0 +1,30 @@ +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + *

This source code is licensed under the MIT license found in the LICENSE file in the root + * directory of this source tree. + * + *

Generated by an internal genrule from Flow types. + * + * @generated + * @nolint + */ + +package com.facebook.fbreact.specs; + +import com.facebook.react.bridge.Promise; +import com.facebook.react.bridge.ReactApplicationContext; +import com.facebook.react.bridge.ReactContextBaseJavaModule; +import com.facebook.react.bridge.ReactMethod; +import com.facebook.react.bridge.ReactModuleWithSpec; +import com.facebook.react.bridge.ReadableMap; +import com.facebook.react.turbomodule.core.interfaces.TurboModule; + +public abstract class NativeTimePickerAndroidSpec extends ReactContextBaseJavaModule implements ReactModuleWithSpec, TurboModule { + public NativeTimePickerAndroidSpec(ReactApplicationContext reactContext) { + super(reactContext); + } + + @ReactMethod + public abstract void open(ReadableMap options, Promise promise); +} diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/BUCK b/ReactAndroid/src/main/java/com/facebook/react/animated/BUCK index c949ede2d4d..edba01a1b14 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/BUCK @@ -27,4 +27,5 @@ rn_android_library( react_native_target("java/com/facebook/react/uimanager:uimanager"), react_native_target("java/com/facebook/react/uimanager/annotations:annotations"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/BUCK b/ReactAndroid/src/main/java/com/facebook/react/devsupport/BUCK index 2395f4309db..39f69cba1f1 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/BUCK @@ -36,6 +36,7 @@ rn_android_library( react_native_target("java/com/facebook/react/packagerconnection:packagerconnection"), react_native_target("res:devsupport"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) rn_android_library( diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/accessibilityinfo/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/accessibilityinfo/BUCK index cd5151c836e..c7d1ffc46c7 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/accessibilityinfo/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/accessibilityinfo/BUCK @@ -17,4 +17,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/core:core"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/BUCK index 7ddc097cabc..60c8584e16c 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/BUCK @@ -15,4 +15,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/core:core"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/BUCK index 74e84bf5f6d..b3e191047dc 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/BUCK @@ -15,4 +15,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/core:core"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BUCK index 72c927348f0..aedfca7dd58 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BUCK @@ -29,4 +29,7 @@ rn_android_library( react_native_target("java/com/facebook/react/modules/network:network"), react_native_target("java/com/facebook/react/modules/websocket:websocket"), ], + exported_deps = [ + react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec"), + ], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/camera/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/camera/BUCK index cdbfb8b48cd..775fd1db0f0 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/camera/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/camera/BUCK @@ -16,4 +16,7 @@ rn_android_library( react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/annotations:annotations"), ], + exported_deps = [ + react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec"), + ], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/core/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/core/BUCK index dea0d2cdbf3..9432c4513c5 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/core/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/core/BUCK @@ -19,4 +19,7 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/util:util"), ], + exported_deps = [ + react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec"), + ], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/BUCK index 6ad9b0c9d96..4a5b7eeb92f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/BUCK @@ -21,4 +21,5 @@ rn_android_library( react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/annotations:annotations"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/BUCK index 2a22a0b8aaf..0f33ea66f71 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/BUCK @@ -17,4 +17,7 @@ rn_android_library( react_native_target("java/com/facebook/react/turbomodule/core/interfaces:interfaces"), react_native_target("java/com/facebook/react/uimanager:uimanager"), ], + exported_deps = [ + react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec"), + ], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/BUCK index 7355162b307..93cae84131f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/BUCK @@ -22,4 +22,5 @@ rn_android_library( react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/annotations:annotations"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/intent/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/intent/BUCK index 99e3d164618..616d73ed750 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/intent/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/intent/BUCK @@ -15,4 +15,5 @@ rn_android_library( react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/annotations:annotations"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/network/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/network/BUCK index c9c10b190f0..fb4b470d71e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/network/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/network/BUCK @@ -27,4 +27,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/core:core"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/BUCK index 224c3a735dc..e947137a59b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/BUCK @@ -14,4 +14,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/core:core"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/share/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/share/BUCK index 2fd9a5a6e61..0e45037b0ce 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/share/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/share/BUCK @@ -14,4 +14,5 @@ rn_android_library( react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/annotations:annotations"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/sound/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/sound/BUCK index a2b08ec0d4b..ac4b1d2f092 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/sound/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/sound/BUCK @@ -18,4 +18,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/uimanager:uimanager"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/BUCK index ca94dfd7f26..4082dcd67a9 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/BUCK @@ -23,4 +23,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/uimanager:uimanager"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/storage/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/storage/BUCK index 518b61d7323..81a13ec3797 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/storage/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/storage/BUCK @@ -17,4 +17,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/common:common"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/BUCK index 2611bb14bf5..30e4988a0fa 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/BUCK @@ -20,6 +20,7 @@ rn_android_library( react_native_target("java/com/facebook/react/turbomodule/core/interfaces:interfaces"), ], exported_deps = [ + react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec"), ":systeminfo-moduleless", ], ) @@ -40,4 +41,5 @@ rn_android_library( react_native_dep("third-party/java/jsr-305:jsr-305"), react_native_target("res:systeminfo"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/BUCK index f1f6dc791a9..9740b735f71 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/BUCK @@ -21,4 +21,5 @@ rn_android_library( react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/annotations:annotations"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/toast/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/toast/BUCK index 9fa4212d088..a297071e700 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/toast/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/toast/BUCK @@ -13,4 +13,5 @@ rn_android_library( react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/annotations:annotations"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/BUCK index 1373eef72f9..d817e4149e3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/BUCK @@ -15,4 +15,5 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/core:core"), ], + exported_deps = [react_native_target("java/com/facebook/fbreact/specs:FBReactNativeSpec")], )