Facebook/react-native
1
0 Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove warnings in some RN Android classes

Browse Source 
Summary: I've been analyzing some issue in RN Android code and I noticed some warnings to clean up

Reviewed By: ejanzer

Differential Revision: D16060522

fbshipit-source-id: 327fa86c24c7dd67ac2376bbd2f0ca4339f106d1
This commit is contained in:
David Vacca authored and Facebook Github Bot committed 2019-07-02 14:47:21 -07:00
1 parent d07ab35bfb
commit a679f592cd
4 files changed
+15 -14
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
+6 -5
View File
@@ -22,6 +22,7 @@ import com.facebook.react.uimanager.annotations.ReactProp;
import com.facebook.react.uimanager.util.ReactFindViewUtil;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
@@ -66,7 +67,7 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
new MatrixMathHelper.MatrixDecompositionContext();
private static double[] sTransformDecompositionArray = new double[16];
public static final HashMap<String, Integer> sStateDescription = new HashMap<String, Integer>();
public static final Map<String, Integer> sStateDescription = new HashMap<>();
static {
sStateDescription.put("busy", R.string.state_busy_description);
@@ -112,7 +113,7 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
int integerZIndex = Math.round(zIndex);
ViewGroupManager.setViewZIndex(view, integerZIndex);
ViewParent parent = view.getParent();
if (parent != null && parent instanceof ReactZIndexedViewGroup) {
if (parent instanceof ReactZIndexedViewGroup) {
((ReactZIndexedViewGroup) parent).updateDrawingOrder();
}
}
@@ -169,9 +170,9 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
if (sStateDescription.containsKey(state)) {
shouldUpdateContentDescription = true;
}
if (state.equals("selected")) {
if ("selected".equals(state)) {
view.setSelected(true);
} else if (state.equals("disabled")) {
} else if ("disabled".equals(state)) {
view.setEnabled(false);
}
}
@@ -213,7 +214,7 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
(ReadableArray) view.getTag(R.id.accessibility_states);
final ReadableMap accessibilityState = (ReadableMap) view.getTag(R.id.accessibility_state);
final String accessibilityHint = (String) view.getTag(R.id.accessibility_hint);
final ArrayList<String> contentDescription = new ArrayList<String>();
final List<String> contentDescription = new ArrayList<>();
if (accessibilityLabel != null) {
contentDescription.add(accessibilityLabel);
}