From a5aaca7d4ff73d814106cfa2ed63900a191ff1bd Mon Sep 17 00:00:00 2001
From: Oleksandr Melnykov <omelnykov@fb.com>
Date: Wed, 14 Aug 2019 04:40:23 -0700
Subject: [PATCH] Migrate RCTAxialGradientView to JS codegen

Summary:
This diff migrates `RCTAxialGradientView` to use generated `RCTAxialGradientViewManagerDelegate` for setting its props. The following base properties have been added to `BaseViewManager`:

```
  protected void setBorderRadius(T view, float borderRadius) {}

  protected void setBorderBottomLeftRadius(T view, float borderRadius) {}

  protected void setBorderBottomRightRadius(T view, float borderRadius) {}

  protected void setBorderTopLeftRadius(T view, float borderRadius) {}

  protected void setBorderTopRightRadius(T view, float borderRadius) {}
```

Reviewed By: JoshuaGross, mdvacca

Differential Revision: D16784173

fbshipit-source-id: f3971985efee2b6e0a5fb248b89c4809305e670c
---
 .../react/uimanager/BaseViewManager.java      | 26 +++++++++++++++++++
 .../uimanager/BaseViewManagerDelegate.java    | 21 +++++++++++++++
 .../FloatPropsNativeComponentViewManager.java | 12 ++++-----
 .../components/GeneratePropsJavaInterface.js  |  3 +--
 .../GeneratePropsJavaInterface-test.js.snap   | 13 +++++-----
 5 files changed, 60 insertions(+), 15 deletions(-)

diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
index f3d841f6505..964c614ed9a 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
@@ -12,6 +12,7 @@ import android.view.ViewParent;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.core.view.ViewCompat;
+import com.facebook.common.logging.FLog;
 import com.facebook.react.R;
 import com.facebook.react.bridge.Dynamic;
 import com.facebook.react.bridge.ReadableArray;
@@ -19,6 +20,7 @@ import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.bridge.ReadableMapKeySetIterator;
 import com.facebook.react.bridge.ReadableType;
 import com.facebook.react.common.MapBuilder;
+import com.facebook.react.common.ReactConstants;
 import com.facebook.react.uimanager.ReactAccessibilityDelegate.AccessibilityRole;
 import com.facebook.react.uimanager.annotations.ReactProp;
 import com.facebook.react.uimanager.util.ReactFindViewUtil;
@@ -363,4 +365,28 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
         .put("topAccessibilityAction", MapBuilder.of("registrationName", "onAccessibilityAction"))
         .build();
   }
+
+  protected void setBorderRadius(T view, float borderRadius) {
+    logUnsupportedPropertyWarning(ViewProps.BORDER_RADIUS);
+  }
+
+  protected void setBorderBottomLeftRadius(T view, float borderRadius) {
+    logUnsupportedPropertyWarning(ViewProps.BORDER_BOTTOM_LEFT_RADIUS);
+  }
+
+  protected void setBorderBottomRightRadius(T view, float borderRadius) {
+    logUnsupportedPropertyWarning(ViewProps.BORDER_BOTTOM_RIGHT_RADIUS);
+  }
+
+  protected void setBorderTopLeftRadius(T view, float borderRadius) {
+    logUnsupportedPropertyWarning(ViewProps.BORDER_TOP_LEFT_RADIUS);
+  }
+
+  protected void setBorderTopRightRadius(T view, float borderRadius) {
+    logUnsupportedPropertyWarning(ViewProps.BORDER_TOP_RIGHT_RADIUS);
+  }
+
+  private void logUnsupportedPropertyWarning(String propName) {
+    FLog.w(ReactConstants.TAG, "%s doesn't support property '%s'", getName(), propName);
+  }
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java
index 4b072f31ee0..674fda984ec 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java
@@ -4,6 +4,7 @@ import android.view.View;
 import androidx.annotation.Nullable;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
+import com.facebook.yoga.YogaConstants;
 
 /**
  * This is a base implementation of {@link ViewManagerDelegate} which supports setting properties
@@ -45,6 +46,26 @@ public abstract class BaseViewManagerDelegate<
       case ViewProps.BACKGROUND_COLOR:
         mViewManager.setBackgroundColor(view, value == null ? 0 : ((Double) value).intValue());
         break;
+      case ViewProps.BORDER_RADIUS:
+        mViewManager.setBorderRadius(
+            view, value == null ? YogaConstants.UNDEFINED : ((Double) value).floatValue());
+        break;
+      case ViewProps.BORDER_BOTTOM_LEFT_RADIUS:
+        mViewManager.setBorderBottomLeftRadius(
+            view, value == null ? YogaConstants.UNDEFINED : ((Double) value).floatValue());
+        break;
+      case ViewProps.BORDER_BOTTOM_RIGHT_RADIUS:
+        mViewManager.setBorderBottomRightRadius(
+            view, value == null ? YogaConstants.UNDEFINED : ((Double) value).floatValue());
+        break;
+      case ViewProps.BORDER_TOP_LEFT_RADIUS:
+        mViewManager.setBorderTopLeftRadius(
+            view, value == null ? YogaConstants.UNDEFINED : ((Double) value).floatValue());
+        break;
+      case ViewProps.BORDER_TOP_RIGHT_RADIUS:
+        mViewManager.setBorderTopRightRadius(
+            view, value == null ? YogaConstants.UNDEFINED : ((Double) value).floatValue());
+        break;
       case ViewProps.ELEVATION:
         mViewManager.setElevation(view, value == null ? 0.0f : ((Double) value).floatValue());
         break;
diff --git a/packages/react-native-codegen/buck_tests/java/FloatPropsNativeComponentViewManager.java b/packages/react-native-codegen/buck_tests/java/FloatPropsNativeComponentViewManager.java
index 25c8698f106..0bdd5736d08 100644
--- a/packages/react-native-codegen/buck_tests/java/FloatPropsNativeComponentViewManager.java
+++ b/packages/react-native-codegen/buck_tests/java/FloatPropsNativeComponentViewManager.java
@@ -25,20 +25,20 @@ public class FloatPropsNativeComponentViewManager extends SimpleViewManager<View
   }
 
   @Override
-  public void setBlurRadius(ViewGroup view, Float value) {}
+  public void setBlurRadius(ViewGroup view, float value) {}
 
   @Override
-  public void setBlurRadius2(ViewGroup view, Float value) {}
+  public void setBlurRadius2(ViewGroup view, float value) {}
 
   @Override
-  public void setBlurRadius3(ViewGroup view, Float value) {}
+  public void setBlurRadius3(ViewGroup view, float value) {}
 
   @Override
-  public void setBlurRadius4(ViewGroup view, Float value) {}
+  public void setBlurRadius4(ViewGroup view, float value) {}
 
   @Override
-  public void setBlurRadius5(ViewGroup view, Float value) {}
+  public void setBlurRadius5(ViewGroup view, float value) {}
 
   @Override
-  public void setBlurRadius6(ViewGroup view, Float value) {}
+  public void setBlurRadius6(ViewGroup view, float value) {}
 }
diff --git a/packages/react-native-codegen/src/generators/components/GeneratePropsJavaInterface.js b/packages/react-native-codegen/src/generators/components/GeneratePropsJavaInterface.js
index 0d64c971050..27810a54ad1 100644
--- a/packages/react-native-codegen/src/generators/components/GeneratePropsJavaInterface.js
+++ b/packages/react-native-codegen/src/generators/components/GeneratePropsJavaInterface.js
@@ -47,8 +47,7 @@ function getJavaValueForProp(prop: PropTypeShape, imports): string {
     case 'Int32TypeAnnotation':
       return 'int value';
     case 'FloatTypeAnnotation':
-      addNullable(imports);
-      return 'Float value';
+      return 'float value';
     case 'NativePrimitiveTypeAnnotation':
       switch (typeAnnotation.name) {
         case 'ColorPrimitive':
diff --git a/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GeneratePropsJavaInterface-test.js.snap b/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GeneratePropsJavaInterface-test.js.snap
index e8723a6450c..61cb4d419f3 100644
--- a/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GeneratePropsJavaInterface-test.js.snap
+++ b/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GeneratePropsJavaInterface-test.js.snap
@@ -147,15 +147,14 @@ Map {
 package com.facebook.react.viewmanagers;
 
 import android.view.View;
-import androidx.annotation.Nullable;
 
 public interface FloatPropNativeComponentManagerInterface<T extends View> {
-  void setBlurRadius(T view, Float value);
-  void setBlurRadius2(T view, Float value);
-  void setBlurRadius3(T view, Float value);
-  void setBlurRadius4(T view, Float value);
-  void setBlurRadius5(T view, Float value);
-  void setBlurRadius6(T view, Float value);
+  void setBlurRadius(T view, float value);
+  void setBlurRadius2(T view, float value);
+  void setBlurRadius3(T view, float value);
+  void setBlurRadius4(T view, float value);
+  void setBlurRadius5(T view, float value);
+  void setBlurRadius6(T view, float value);
 }
 ",
 }