From a5a94ce786dbe0991facca55eadddc0409ed4e92 Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Thu, 28 Jan 2021 14:01:07 -0800 Subject: [PATCH] Support RCTModernEventEmitter+RCTEventEmitter in ReactTextInputEvent Event class Summary: Support RCTModernEventEmitter+RCTEventEmitter in an Event class(es). This improves perf in Fabric. Migrate any constructor callsites to the new constructor and deprecate the previous one. Changelog: [Internal] Reviewed By: PeteTheHeat, mdvacca Differential Revision: D26056680 fbshipit-source-id: 2a57f15c01a585af9ddbe08cf6dd60922d4f64b3 --- .../views/textinput/ReactTextInputEvent.java | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputEvent.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputEvent.java index c367f389fc8..2285fbfafb3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputEvent.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputEvent.java @@ -7,11 +7,10 @@ package com.facebook.react.views.textinput; +import androidx.annotation.Nullable; import com.facebook.react.bridge.Arguments; import com.facebook.react.bridge.WritableMap; import com.facebook.react.uimanager.events.Event; -import com.facebook.react.uimanager.events.RCTEventEmitter; -import com.facebook.react.uimanager.events.RCTModernEventEmitter; /** * Event emitted by EditText native view when text changes. VisibleForTesting from {@link @@ -52,18 +51,9 @@ public class ReactTextInputEvent extends Event { return false; } + @Nullable @Override - public void dispatch(RCTEventEmitter rctEventEmitter) { - rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData()); - } - - @Override - public void dispatchModern(RCTModernEventEmitter rctEventEmitter) { - rctEventEmitter.receiveEvent( - getSurfaceId(), getViewTag(), getEventName(), serializeEventData()); - } - - private WritableMap serializeEventData() { + protected WritableMap getEventData() { WritableMap eventData = Arguments.createMap(); WritableMap range = Arguments.createMap(); range.putDouble("start", mRangeStart);