Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix CircleCI by adding dependency on JSI to cxxreact (#29087)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/29087

D21908523 added an implicit dependency on `jsi.h` to use functions like `asObject`, etc. For some reason this doesn't break the build with BUCK (??) but it does with cocoapods. Adding the dep to the cxxreact podspec and regenerating offline mirrors to unbreak CircleCI. Also adding the BUCK dep and include statement for good measure.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D21924592

fbshipit-source-id: 295c0670c6499e1195ba3c3a3320c6aee13bc025
This commit is contained in:
Emily Janzer
2020-06-07 17:55:16 -07:00
committed by Facebook GitHub Bot
parent 6860cb0775
commit a50fa552a7
4 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/cxxreact/NativeToJsBridge.cpp
+1
View File
@@ -11,6 +11,7 @@
#include <folly/MoveWrapper.h>
#include <folly/json.h>
#include <glog/logging.h>
#include <jsi/jsi.h>
#include <reactperflogger/BridgeNativeModulePerfLogger.h>
#include "Instance.h"