From a4ef25616775be3375e5f82e79d214bb95a4df60 Mon Sep 17 00:00:00 2001 From: Alexey Lang Date: Tue, 2 Oct 2018 05:43:14 -0700 Subject: [PATCH] Bump up the buffer size and show a warning if the trace might be truncated Summary: The current buffer size isn't enough even to capture a short TTI trace. Reviewed By: mhorowitz Differential Revision: D10112538 fbshipit-source-id: 266fa6ffa916049245b21d7725a364d75589c776 --- React/CxxBridge/RCTCxxBridge.mm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm index 62b13fa9110..2241f9830a3 100644 --- a/React/CxxBridge/RCTCxxBridge.mm +++ b/React/CxxBridge/RCTCxxBridge.mm @@ -1258,6 +1258,10 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithBundleURL:(__unused NSURL *)bundleUR NSData *logData = [log dataUsingEncoding:NSUTF8StringEncoding]; callback(logData); #if WITH_FBSYSTRACE + if (![RCTFBSystrace verifyTraceSize:logData.length]) { + RCTLogWarn(@"Your FBSystrace trace might be truncated, try to bump up the buffer size" + " in RCTFBSystrace.m or capture a shorter trace"); + } [RCTFBSystrace unregisterCallbacks]; #endif });