From a2e46e43fb980d91542fa9c052183568056a0b79 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 18 May 2020 12:55:57 -0700 Subject: [PATCH] Extends view flattening algorithm to support flattening of absolute positioned views Summary: This diff extends view flattening algorithm to support flattening of absolute positioned views. changeLog:[Internal] internal change in fabric Reviewed By: shergin Differential Revision: D21614519 fbshipit-source-id: e33a41677a332bb58d5e5dcedbffd614a8416a45 --- ReactCommon/fabric/components/view/ViewShadowNode.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ReactCommon/fabric/components/view/ViewShadowNode.cpp b/ReactCommon/fabric/components/view/ViewShadowNode.cpp index 6f58a7a0b4a..b503bb2986b 100644 --- a/ReactCommon/fabric/components/view/ViewShadowNode.cpp +++ b/ReactCommon/fabric/components/view/ViewShadowNode.cpp @@ -43,8 +43,9 @@ void ViewShadowNode::initialize() noexcept { viewProps.pointerEvents == PointerEventsMode::None || !viewProps.nativeId.empty() || viewProps.accessible || viewProps.opacity != 1.0 || viewProps.transform != Transform{} || - viewProps.zIndex != 0 || viewProps.getClipsContentToBounds() || - viewProps.yogaStyle.positionType() == YGPositionTypeAbsolute || + (viewProps.zIndex != 0 && + viewProps.yogaStyle.positionType() == YGPositionTypeAbsolute) || + viewProps.getClipsContentToBounds() || isColorMeaningful(viewProps.shadowColor); bool formsView = isColorMeaningful(viewProps.backgroundColor) ||