Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Collapsing of mutation instructions

Browse Source 
Summary:
This diff fixes the algorithm that collapses mutation instructions in Fabric Android
The problem was that we were always relying on the fact that the oldShadowNode is present as part of the mutation instruction (which is not correct for mutation instructions of type CREATE)

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D18411360

fbshipit-source-id: 36f5e75f792db87003fcaef2ddcd9452415a0ad6
This commit is contained in:
David Vacca
2019-11-09 10:36:30 -08:00
committed by Facebook Github Bot
parent 5410b63857
commit a20939f49d
1 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp
+26 -6
View File
@@ -574,13 +574,24 @@ void Binding::schedulerDidFinishTransaction(
auto &mutations = mountingTransaction->getMutations();
facebook::better::set<int> createAndDeleteTagsToProcess;
// When collapseDeleteCreateMountingInstructions_ is enabled, the
// createAndDeleteTagsToProcess set will contain all the tags belonging to
// CREATE and DELETE mutation instructions that needs to be processed. If a
// CREATE or DELETE mutation instruction does not belong in the set, it means
// that the we received a pair of mutation instructions: DELETE - CREATE and
// it is not necessary to create or delete on the screen.
if (collapseDeleteCreateMountingInstructions_) {
for (const auto &mutation : mutations) {
if (mutation.type == ShadowViewMutation::Delete) {
// TAG on 'Delete' mutation instructions are part of the
// oldChildShadowView
createAndDeleteTagsToProcess.insert(mutation.oldChildShadowView.tag);
} else if (mutation.type == ShadowViewMutation::Create) {
int tag = mutation.oldChildShadowView.tag;
if (createAndDeleteTagsToProcess.find(tag) != createAndDeleteTagsToProcess.end()) {
// TAG on 'Create' mutation instructions are part of the
// newChildShadowView
int tag = mutation.newChildShadowView.tag;
if (createAndDeleteTagsToProcess.find(tag) ==
createAndDeleteTagsToProcess.end()) {
createAndDeleteTagsToProcess.insert(tag);
} else {
createAndDeleteTagsToProcess.erase(tag);
@@ -610,10 +621,19 @@ void Binding::schedulerDidFinishTransaction(
auto mutationType = mutation.type;
if (collapseDeleteCreateMountingInstructions_ &&
(mutationType == ShadowViewMutation::Create || mutationType == ShadowViewMutation::Delete) &&
createAndDeleteTagsToProcess.size() > 0 &&
createAndDeleteTagsToProcess.find(mutation.newChildShadowView.tag) == createAndDeleteTagsToProcess.end()) {
continue;
(mutationType == ShadowViewMutation::Create ||
mutationType == ShadowViewMutation::Delete) &&
createAndDeleteTagsToProcess.size() > 0) {
// The TAG on 'Delete' mutation instructions are part of the
// oldChildShadowView. On the other side, the TAG on 'Create' mutation
// instructions are part of the newChildShadowView
int tag = mutationType == ShadowViewMutation::Create
? mutation.newChildShadowView.tag
: mutation.oldChildShadowView.tag;
if (createAndDeleteTagsToProcess.find(tag) ==
createAndDeleteTagsToProcess.end()) {
continue;
}
}
bool isVirtual = newChildShadowView.layoutMetrics == EmptyLayoutMetrics &&