From a034841fd68a93778d4999f8bc540cf6a5fef8d4 Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Mon, 3 Nov 2025 06:06:09 -0800 Subject: [PATCH] Fix likely bug in maintainVisibleContentPosition (#54363) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54363 The calculus for active scroll maintainVisibleContentPosition is not isomorphic between ReactHorizontalScrollView and ReactScrollView. Additiionally, it doesn't make sense that we would use an x-offset in a y-offset calculation. This fixes a likely bug where the OverScroller's x-offset is used to compute the scroll animation update in ReactScrollView.recreateFlingAnimation. ## Changelog [Android][Fixed] - Issue with restarting scroll in maintainVisibleContentPosition Reviewed By: javache Differential Revision: D86021007 fbshipit-source-id: 0d7febcbccd59df534bacbba7f1b5bb5085fa95f --- .../java/com/facebook/react/views/scroll/ReactScrollView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java index 18ad9a16928..b0f62037bba 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java @@ -1367,7 +1367,7 @@ public class ReactScrollView extends ScrollView mScroller.fling(getScrollX(), scrollY, 0, (int) flingVelocityY, 0, 0, 0, Integer.MAX_VALUE); } else { - scrollTo(getScrollX(), scrollY + (mScroller.getCurrX() - scrollerYBeforeTick)); + scrollTo(getScrollX(), scrollY + (mScroller.getCurrY() - scrollerYBeforeTick)); } } }