From 9f12fce53bf29aaa8c0ecf53fa3633834a13ad5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20Kwas=CC=81niewski?= Date: Wed, 18 Dec 2024 07:14:04 -0800 Subject: [PATCH] fix(iOS): remove unused RCTTurboModuleManagerDelegate method (#48290) Summary: Hey, this PR removes unused method from RCTAppDelegate. The only called method from RCTTurboModuleManagerDelegate is `getTurboModule:jsInvoker`, the `getTurboModule:initParams:` is never called. https://github.com/facebook/react-native/blob/5a81ceed2a6c974211e6a238efee3eea68b9568a/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm#L207 ## Changelog: [INTERNAL] [REMOVED] - remove unused RCTTurboModuleManagerDelegate method Pull Request resolved: https://github.com/facebook/react-native/pull/48290 Test Plan: CI Green, ensure everything works as before Reviewed By: javache Differential Revision: D67392056 Pulled By: cipolleschi fbshipit-source-id: e7f35f81c48cdc163cfff45987e0b7eb022cbf7d --- .../react-native/Libraries/AppDelegate/RCTAppDelegate.mm | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm b/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm index 224cb2f086e..e00c1d5fa2f 100644 --- a/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm +++ b/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm @@ -221,12 +221,6 @@ using namespace facebook::react; return DefaultTurboModules::getTurboModule(name, jsInvoker); } -- (std::shared_ptr)getTurboModule:(const std::string &)name - initParams:(const ObjCTurboModule::InitParams &)params -{ - return nullptr; -} - - (id)getModuleInstanceFromClass:(Class)moduleClass { return RCTAppSetupDefaultModuleFromClass(moduleClass, self.dependencyProvider);