From 9ef6d606a78f1559675f4abec8ab2d3e2e37ef54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Tue, 30 Jan 2024 06:09:27 -0800 Subject: [PATCH] Fix broken ReactNativeFeatureFlagsTest test on iOS (#42699) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42699 Changelog: [internal] The test was fine on C++. The reason is probably that C++ destroys the process between tests (effectively resetting singletons) while iOS doesn't. This fixes the test by implementing a correct `TearDown` method to reset the flags. Reviewed By: rshest Differential Revision: D53178474 fbshipit-source-id: 6a0f67f1a59fe47f73a495344d4c0daa8eafa3c4 --- .../react/featureflags/tests/ReactNativeFeatureFlagsTest.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-native/ReactCommon/react/featureflags/tests/ReactNativeFeatureFlagsTest.cpp b/packages/react-native/ReactCommon/react/featureflags/tests/ReactNativeFeatureFlagsTest.cpp index c6ea0528ecf..ddcefef18e6 100644 --- a/packages/react-native/ReactCommon/react/featureflags/tests/ReactNativeFeatureFlagsTest.cpp +++ b/packages/react-native/ReactCommon/react/featureflags/tests/ReactNativeFeatureFlagsTest.cpp @@ -28,6 +28,10 @@ class ReactNativeFeatureFlagsTest : public testing::Test { void SetUp() override { overrideAccessCount = 0; } + + void TearDown() override { + ReactNativeFeatureFlags::dangerouslyReset(); + } }; TEST_F(ReactNativeFeatureFlagsTest, providesDefaults) {