From 9ede538b7515fc80cae1bed44c573eb2bc4bb525 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Wed, 20 Mar 2019 18:05:07 -0700 Subject: [PATCH] Fabric: Removing an assert in YogaLayoutableShadowNode Summary: Conceptually, this assert is correct, however, sometimes a new node got allocated by same address as old parent node (which does not exist already) which makes the assert fires. Reviewed By: mdvacca Differential Revision: D14533070 fbshipit-source-id: 3fcc71c25e7d724180dc85aaf2457227d22ddba0 --- .../fabric/components/view/yoga/YogaLayoutableShadowNode.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/ReactCommon/fabric/components/view/yoga/YogaLayoutableShadowNode.cpp b/ReactCommon/fabric/components/view/yoga/YogaLayoutableShadowNode.cpp index 7b198efc687..026b7f6f23f 100644 --- a/ReactCommon/fabric/components/view/yoga/YogaLayoutableShadowNode.cpp +++ b/ReactCommon/fabric/components/view/yoga/YogaLayoutableShadowNode.cpp @@ -80,9 +80,6 @@ void YogaLayoutableShadowNode::appendChild(YogaLayoutableShadowNode *child) { auto yogaNodeRawPtr = &yogaNode_; auto childYogaNodeRawPtr = &child->yogaNode_; - // Cloned node must not be reinserted to the same parent. - assert(childYogaNodeRawPtr->getOwner() != yogaNodeRawPtr); - if (childYogaNodeRawPtr->getOwner() != nullptr) { child = static_cast( cloneAndReplaceChild(child, yogaNode_.getChildren().size()));