From 9e399d940a34269ca92e314598e1dce2e7eeafc6 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Thu, 7 Nov 2024 04:57:49 -0800 Subject: [PATCH] Remove XCBeautify from CI (#47482) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47482 XCBeautify swallow some errors, especially all the linker errors when some symbol is not defined. The full error is not available in the raw log either. This makes much harder to debug those issues when they happen. We can remove xcbeautify for the time being, while we find a better solution. ## Changelog [Internal] - Remove XCBeautify from ci Reviewed By: dmytrorykun Differential Revision: D65596745 fbshipit-source-id: 0550d4cbeadc5bec8acc61b5edc1320d3445bcaf --- .github/actions/prepare-ios-tests/action.yml | 3 --- .github/actions/test-ios-rntester/action.yml | 8 ++++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/actions/prepare-ios-tests/action.yml b/.github/actions/prepare-ios-tests/action.yml index daa43b3b64e..6465f0db99b 100644 --- a/.github/actions/prepare-ios-tests/action.yml +++ b/.github/actions/prepare-ios-tests/action.yml @@ -3,9 +3,6 @@ description: Prepare iOS Tests runs: using: composite steps: - - name: brew install xcbeautify - run: brew install xcbeautify - shell: bash - name: Run Ruby Tests shell: bash run: | diff --git a/.github/actions/test-ios-rntester/action.yml b/.github/actions/test-ios-rntester/action.yml index 61c28f6b8b1..25acfe2cd60 100644 --- a/.github/actions/test-ios-rntester/action.yml +++ b/.github/actions/test-ios-rntester/action.yml @@ -121,21 +121,21 @@ runs: if: ${{ inputs.run-unit-tests != 'true' && inputs.run-e2e-tests == 'false' }} shell: bash run: | - set -o pipefail && xcodebuild build \ + xcodebuild build \ -workspace packages/rn-tester/RNTesterPods.xcworkspace \ -scheme RNTester \ - -sdk iphonesimulator | xcbeautify + -sdk iphonesimulator - name: Build RNTester (E2E Tests) shell: bash if: ${{ inputs.run-e2e-tests == 'true' }} run: | - set -o pipefail && xcodebuild \ + xcodebuild \ -scheme "RNTester" \ -workspace packages/rn-tester/RNTesterPods.xcworkspace \ -configuration "${{ inputs.flavor }}" \ -sdk "iphonesimulator" \ -destination "generic/platform=iOS Simulator" \ - -derivedDataPath "/tmp/RNTesterBuild" | xcbeautify + -derivedDataPath "/tmp/RNTesterBuild" echo "Print path to *.app file" find "/tmp/RNTesterBuild" -type d -name "*.app"