From 9e2e7545551563edfdc25b6ad5e6e1bb0df95d3b Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Tue, 17 Dec 2019 18:24:06 -0800 Subject: [PATCH] Fabric: Removing a workaround from ComponentDescriptorRegistry Summary: We used that on iOS only before we had `ComponentDescriptorProviderRequest`. Now iOS does not use `_fallbackComponentDescriptor`. On Android we still use `_fallbackComponentDescriptor` but set that explicitly via `ComponentDescriptorRegistry::setFallbackComponentDescriptor`. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D19103296 fbshipit-source-id: fb2a2142afb183145fd3c8e48f620cb3f316c0bb --- .../fabric/uimanager/ComponentDescriptorRegistry.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp b/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp index 1c53384f986..6df7aace5d8 100644 --- a/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp +++ b/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp @@ -39,12 +39,6 @@ void ComponentDescriptorRegistry::add( _registryByHandle[componentDescriptorProvider.handle] = sharedComponentDescriptor; _registryByName[componentDescriptorProvider.name] = sharedComponentDescriptor; - - if (strcmp(componentDescriptorProvider.name, "UnimplementedNativeView") == - 0) { - auto *self = const_cast(this); - self->setFallbackComponentDescriptor(sharedComponentDescriptor); - } } void ComponentDescriptorRegistry::registerComponentDescriptor(