From 9dfd26eaaf719ba62e552bcbe66afaaac7ffebda Mon Sep 17 00:00:00 2001 From: riteshshukla04 Date: Fri, 10 Apr 2026 09:04:44 -0700 Subject: [PATCH] fix: formData upload broken in debug builds (#56406) Summary: So the formData Upload in fetch is broken on 0.85 on main. I tracked down this PR https://github.com/facebook/react-native/pull/55456 Also reported here https://github.com/facebook/react-native/issues/56404 RCA:- ``` body.isOneShot() body.writeTo(buffer) // This is draining inner file InputStreams ``` Fix is to walk to each children of multipart and check for Oneshot ## Changelog: [ANDROID][FIXED] - FormData uploads broken in debug builds Pull Request resolved: https://github.com/facebook/react-native/pull/56406 Test Plan: Tested on RN tester image Reviewed By: fabriziocucci, huntie Differential Revision: D100258994 Pulled By: alanleedev fbshipit-source-id: aeda47d45db2152027598c949f0e602a586c4cb3 --- .../facebook/react/modules/network/NetworkEventUtil.kt | 8 ++++++++ .../com/facebook/react/modules/network/RequestBodyUtil.kt | 2 ++ 2 files changed, 10 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt index 781f25d7137..8965f140ef6 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt @@ -19,6 +19,7 @@ import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags import java.io.IOException import java.net.SocketTimeoutException import okhttp3.Headers +import okhttp3.MultipartBody import okhttp3.RequestBody import okio.Buffer @@ -263,6 +264,13 @@ internal object NetworkEventUtil { return "[Preview unavailable]" } + // MultipartBody does not propagate isOneShot() from its parts, so check each + // part explicitly. Reading a one-shot part here would drain the underlying + // stream and cause the real request to fail. + if (body is MultipartBody && body.parts().any { it.body().isOneShot() }) { + return "[Preview unavailable]" + } + return try { val buffer = Buffer() body.writeTo(buffer) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/RequestBodyUtil.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/RequestBodyUtil.kt index 3fa7e6aa51e..eb111d312ac 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/RequestBodyUtil.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/RequestBodyUtil.kt @@ -146,6 +146,8 @@ internal object RequestBodyUtil { } } + override fun isOneShot(): Boolean = true + @Throws(IOException::class) override fun writeTo(sink: BufferedSink) { var source: Source? = null