From 9cefc96e43d2b9326b88c6aa19c3db2c58013ddf Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 7 Oct 2019 11:33:17 -0700 Subject: [PATCH] Remove redundant props from Picker Summary: Props are being ignored on native side, let's get rid of them. Reviewed By: TheSavior Differential Revision: D17765185 fbshipit-source-id: d3625dd25d2e41a49e701d54fe9a7b74cd47786c --- Libraries/Components/Picker/PickerIOS.ios.js | 4 ---- Libraries/Components/Picker/RCTPickerNativeComponent.js | 2 -- .../Picker/__tests__/__snapshots__/Picker-test.js.snap | 4 ---- 3 files changed, 10 deletions(-) diff --git a/Libraries/Components/Picker/PickerIOS.ios.js b/Libraries/Components/Picker/PickerIOS.ios.js index 7a642f97120..340069908be 100644 --- a/Libraries/Components/Picker/PickerIOS.ios.js +++ b/Libraries/Components/Picker/PickerIOS.ios.js @@ -44,8 +44,6 @@ type RCTPickerIOSType = Class< $ReadOnly<{| items: $ReadOnlyArray, onChange: (event: PickerIOSChangeEvent) => void, - onResponderTerminationRequest: () => boolean, - onStartShouldSetResponder: () => boolean, selectedIndex: number, style?: ?TextStyleProp, testID?: ?string, @@ -119,8 +117,6 @@ class PickerIOS extends React.Component { items={this.state.items} selectedIndex={this.state.selectedIndex} onChange={this._onChange} - onStartShouldSetResponder={() => true} - onResponderTerminationRequest={() => false} /> ); diff --git a/Libraries/Components/Picker/RCTPickerNativeComponent.js b/Libraries/Components/Picker/RCTPickerNativeComponent.js index 6db9d496fca..541b1ccf221 100644 --- a/Libraries/Components/Picker/RCTPickerNativeComponent.js +++ b/Libraries/Components/Picker/RCTPickerNativeComponent.js @@ -35,8 +35,6 @@ type RCTPickerIOSType = Class< $ReadOnly<{| items: $ReadOnlyArray, onChange: (event: PickerIOSChangeEvent) => void, - onResponderTerminationRequest: () => boolean, - onStartShouldSetResponder: () => boolean, selectedIndex: number, style?: ?TextStyleProp, testID?: ?string, diff --git a/Libraries/Components/Picker/__tests__/__snapshots__/Picker-test.js.snap b/Libraries/Components/Picker/__tests__/__snapshots__/Picker-test.js.snap index 00b157697b7..fe9df259461 100644 --- a/Libraries/Components/Picker/__tests__/__snapshots__/Picker-test.js.snap +++ b/Libraries/Components/Picker/__tests__/__snapshots__/Picker-test.js.snap @@ -18,8 +18,6 @@ exports[` should render as when mocked 1`] = ` ] } onChange={[Function]} - onResponderTerminationRequest={[Function]} - onStartShouldSetResponder={[Function]} selectedIndex={0} style={ Array [ @@ -51,8 +49,6 @@ exports[` should render as when not mocked 1`] = ` ] } onChange={[Function]} - onResponderTerminationRequest={[Function]} - onStartShouldSetResponder={[Function]} selectedIndex={0} style={ Array [