From 9c770f57182479ad55f3ad1fc2185febbe791813 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Thu, 13 Aug 2026 07:11:06 -0700 Subject: [PATCH] Fix Maestro Cloud project ID reference (#57943) Summary: - read the Maestro Cloud project ID from the repository secret in both iOS and Android jobs - match the existing repository configuration and unblock input validation The failing main run resolved vars.MAESTRO_CLOUD_PROJECT_ID to an empty string because MAESTRO_CLOUD_PROJECT_ID is configured as a GitHub Actions secret. Changelog: [Internal] [Changed] - Pull Request resolved: https://github.com/react/react-native/pull/57943 Test Plan: - node_modules/.bin/prettier --check .github/workflows/test-all.yml - git diff --check Reviewed By: huntie Differential Revision: D115871650 Pulled By: cortinico fbshipit-source-id: f7475fa8fcd30e334b9bf3d361f6f718bd0ca7e4 --- .github/workflows/test-all.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index e09e5651acf..f699cbd0ef2 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -190,7 +190,7 @@ jobs: - name: Validate Maestro Cloud inputs env: MAESTRO_CLOUD_API_KEY: ${{ secrets.MAESTRO_CLOUD_API_KEY }} - MAESTRO_CLOUD_PROJECT_ID: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }} + MAESTRO_CLOUD_PROJECT_ID: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }} run: | test -n "$MAESTRO_CLOUD_API_KEY" test -n "$MAESTRO_CLOUD_PROJECT_ID" @@ -200,7 +200,7 @@ jobs: uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1 with: api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }} - project-id: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }} + project-id: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }} app-file: /tmp/RNTesterBuild/RNTester.app workspace: packages/rn-tester/.maestro branch: ${{ github.head_ref || github.ref_name }} @@ -402,7 +402,7 @@ jobs: - name: Validate Maestro Cloud inputs env: MAESTRO_CLOUD_API_KEY: ${{ secrets.MAESTRO_CLOUD_API_KEY }} - MAESTRO_CLOUD_PROJECT_ID: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }} + MAESTRO_CLOUD_PROJECT_ID: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }} run: | test -n "$MAESTRO_CLOUD_API_KEY" test -n "$MAESTRO_CLOUD_PROJECT_ID" @@ -412,7 +412,7 @@ jobs: uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1 with: api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }} - project-id: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }} + project-id: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }} app-file: /tmp/rntester-android/app-x86-release.apk workspace: packages/rn-tester/.maestro branch: ${{ github.head_ref || github.ref_name }}