From 9bc2050a792e36969d93d0181d28b21a785d575d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ma=C5=82ecki?= Date: Tue, 31 Mar 2026 08:32:57 -0700 Subject: [PATCH] Fix return type for Bridging::fromJs (#56246) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56246 Fixes return type to receive correct generic types. Before: ``` static std::pair fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr &jsInvoker) ``` After: ``` static std::pair fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr &jsInvoker) ``` Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D98292820 fbshipit-source-id: bb7791ace2391240dd50ece55b2a2ce905a51115 --- packages/react-native/ReactCommon/react/bridging/Array.h | 2 +- scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/react-native/ReactCommon/react/bridging/Array.h b/packages/react-native/ReactCommon/react/bridging/Array.h index 89108201ce0..03ee6e464df 100644 --- a/packages/react-native/ReactCommon/react/bridging/Array.h +++ b/packages/react-native/ReactCommon/react/bridging/Array.h @@ -76,7 +76,7 @@ struct Bridging> : array_detail::BridgingStatic struct Bridging> : array_detail::BridgingStatic, 2> { - static std::pair + static std::pair fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr &jsInvoker) { return std::make_pair( diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index b6c191e12db..3c98072c1c3 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -10417,7 +10417,7 @@ struct facebook::react::Bridging> { template struct facebook::react::Bridging> : public facebook::react::array_detail::BridgingStatic, 2> { - public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); + public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); } template diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index d645401c94d..4b536dc5211 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -10244,7 +10244,7 @@ struct facebook::react::Bridging> { template struct facebook::react::Bridging> : public facebook::react::array_detail::BridgingStatic, 2> { - public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); + public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); } template diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index 18dfe51e5af..1880fc1701e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -12875,7 +12875,7 @@ struct facebook::react::Bridging> { template struct facebook::react::Bridging> : public facebook::react::array_detail::BridgingStatic, 2> { - public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); + public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); } template diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index ea0a658ab90..916dea2c0e1 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -12702,7 +12702,7 @@ struct facebook::react::Bridging> { template struct facebook::react::Bridging> : public facebook::react::array_detail::BridgingStatic, 2> { - public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); + public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); } template diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index ba6cbfd7ffd..7f253562053 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -7180,7 +7180,7 @@ struct facebook::react::Bridging> { template struct facebook::react::Bridging> : public facebook::react::array_detail::BridgingStatic, 2> { - public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); + public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); } template diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index b05c2e09a06..b7bcf7594dc 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -7171,7 +7171,7 @@ struct facebook::react::Bridging> { template struct facebook::react::Bridging> : public facebook::react::array_detail::BridgingStatic, 2> { - public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); + public static std::pair fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr& jsInvoker); } template