From 9bb7afbb41efbd2257389e6aed0ad5f2efbeb1bb Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Tue, 25 Jul 2023 03:14:56 -0700 Subject: [PATCH] Remove StaticFrameworks jobs (#38551) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38551 I think we can safely remove the StaticFrameworks tests: the DynamicFrameworks are stricter than the static, so if something works in a dynamic frameworks setup, it will work also in the static framework one. we can safely delete the following tests - test_ios_template-NewArch-Debug-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-NewArch-Debug-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-NewArch-Release-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-NewArch-Release-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-OldArch-Debug-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-OldArch-Debug-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-OldArch-Release-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-OldArch-Release-WithoutFlipper-JSC-StaticFrameworks - test_ios_rntester-NewArch-Hermes-StaticFrameworks - test_ios_rntester-NewArch-JSC-StaticFrameworks - test_ios_rntester-OldArch-Hermes-StaticFrameworks - test_ios_rntester-OldArch-JSC-StaticFrameworks ## Changelog [Internal] - Remove static frameworks tests in CircleCI Reviewed By: dmytrorykun Differential Revision: D47669902 fbshipit-source-id: 4888bbf88bb23284e410936910e5f71c969408d0 --- .circleci/config.yml | 61 +++++--------------------------------------- 1 file changed, 7 insertions(+), 54 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ac8d9532a77..8f141086997 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -259,7 +259,7 @@ commands: command: cp packages/rn-tester/Podfile.lock packages/rn-tester/Podfile.lock.bak - restore_cache: keys: - # The committed lockfile is generated using USE_FRAMEWORKS=0 and USE_HERMES=1 so it could load an outdated cache if a change + # The committed lockfile is generated using static libraries and USE_HERMES=1 so it could load an outdated cache if a change # only affects the frameworks or hermes config. To help prevent this also cache based on the content of Podfile. - *pods_cache_key - steps: << parameters.steps >> @@ -847,7 +847,7 @@ jobs: default: "StaticLibraries" description: Which kind of option we want to use for `use_frameworks!` type: enum - enum: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"] + enum: ["StaticLibraries", "DynamicFrameworks"] ruby_version: default: "2.6.10" description: The version of ruby that must be used @@ -898,9 +898,7 @@ jobs: export NO_FLIPPER=1 fi - if [[ << parameters.use_frameworks >> == "StaticFrameworks" ]]; then - export USE_FRAMEWORKS=static - elif [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then + if [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then export USE_FRAMEWORKS=dynamic fi @@ -960,9 +958,9 @@ jobs: enum: ["NewArch", "OldArch"] use_frameworks: default: "StaticLibraries" - description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "StaticFrameworks", "DynamicFrameworks" + description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks" type: enum - enum: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"] + enum: ["StaticLibraries", "DynamicFrameworks"] ruby_version: default: "2.6.10" description: The version of ruby that must be used @@ -997,11 +995,6 @@ jobs: export USE_HERMES=0 fi - if [[ << parameters.use_frameworks >> == "StaticFrameworks" ]]; then - export NO_FLIPPER=1 - export USE_FRAMEWORKS=static - fi - if [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then export NO_FLIPPER=1 export USE_FRAMEWORKS=dynamic @@ -1684,18 +1677,13 @@ workflows: flavor: ["Debug", "Release"] jsengine: ["Hermes", "JSC"] flipper: ["WithFlipper", "WithoutFlipper"] - use_frameworks: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"] + use_frameworks: ["StaticLibraries", "DynamicFrameworks"] exclude: - architecture: "NewArch" flavor: "Release" jsengine: "Hermes" flipper: "WithFlipper" use_frameworks: "StaticLibraries" - - architecture: "NewArch" - flavor: "Release" - jsengine: "Hermes" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - architecture: "NewArch" flavor: "Release" jsengine: "Hermes" @@ -1706,11 +1694,6 @@ workflows: jsengine: "JSC" flipper: "WithFlipper" use_frameworks: "StaticLibraries" - - architecture: "NewArch" - flavor: "Release" - jsengine: "JSC" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - architecture: "NewArch" flavor: "Release" jsengine: "JSC" @@ -1721,11 +1704,6 @@ workflows: jsengine: "Hermes" flipper: "WithFlipper" use_frameworks: "StaticLibraries" - - architecture: "OldArch" - flavor: "Release" - jsengine: "Hermes" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - architecture: "OldArch" flavor: "Release" jsengine: "Hermes" @@ -1736,36 +1714,11 @@ workflows: jsengine: "JSC" flipper: "WithFlipper" use_frameworks: "StaticLibraries" - - architecture: "OldArch" - flavor: "Release" - jsengine: "JSC" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - architecture: "OldArch" flavor: "Release" jsengine: "JSC" flipper: "WithFlipper" use_frameworks: "DynamicFrameworks" - - architecture: "NewArch" - flavor: "Debug" - jsengine: "Hermes" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - - architecture: "NewArch" - flavor: "Debug" - jsengine: "JSC" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - - architecture: "OldArch" - flavor: "Debug" - jsengine: "Hermes" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - - architecture: "OldArch" - flavor: "Debug" - jsengine: "JSC" - flipper: "WithFlipper" - use_frameworks: "StaticFrameworks" - architecture: "NewArch" flavor: "Debug" jsengine: "Hermes" @@ -1805,7 +1758,7 @@ workflows: parameters: architecture: ["NewArch", "OldArch"] jsengine: ["Hermes", "JSC"] - use_frameworks: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"] + use_frameworks: ["StaticLibraries", "DynamicFrameworks"] - test_ios: name: "Test iOS with Ruby 2.7.7" run_unit_tests: true