From 9b2a54e4be46f6d3e6792ee54837b30cecfbe29f Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Tue, 8 Sep 2026 00:56:49 -0700 Subject: [PATCH] Remove remaining private includes from scheduler headers (#58137) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58137 Under the C++ Stable API RFC, `react/renderer/scheduler:scheduler` is a "for frameworks" module, but its exported headers still reached two private modules: - `Scheduler.h` included `react/performance/timeline/PerformanceEntryReporter.h` and `react/renderer/observers/events/EventPerformanceLogger.h`. Both are only used as `std::shared_ptr` data members, so forward declarations are sufficient and the includes move to `Scheduler.cpp`. - `SchedulerToolbox.h` included `react/renderer/leakchecker/LeakChecker.h` but never named anything from it. `leakchecker` is not even a dependency of the scheduler target, so the include is dead and is simply removed. `react/renderer/observers/events:events` had no other header-level consumer in ReactCommon, so it is now cleanly private. `react/performance/timeline:timeline` is still reached from `RuntimeScheduler.h` and `NativePerformance.h`, which are handled separately. After this, no scheduler header includes a private module directly. Changelog: [Internal] Reviewed By: javache Differential Revision: D116909093 fbshipit-source-id: 84ecaf003d983034f2a1fa724a034c7050343443 --- .../ReactCommon/react/renderer/scheduler/Scheduler.cpp | 2 ++ .../ReactCommon/react/renderer/scheduler/Scheduler.h | 4 ++-- .../ReactCommon/react/renderer/scheduler/SchedulerToolbox.h | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp index a42669c53bb..e81660b312e 100644 --- a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp +++ b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp @@ -15,12 +15,14 @@ #include #include #include +#include #include #include #include #include #include #include +#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h index 5723f4d0e54..59c8f6ceac8 100644 --- a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h +++ b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h @@ -16,14 +16,12 @@ #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -37,6 +35,8 @@ namespace facebook::react { class CdpMetricsReporter; class CdpPerfIssuesReporter; +class EventPerformanceLogger; +class PerformanceEntryReporter; class ViewTransitionModule; /* diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/SchedulerToolbox.h b/packages/react-native/ReactCommon/react/renderer/scheduler/SchedulerToolbox.h index 7d78c1ed524..50ddbdca801 100644 --- a/packages/react-native/ReactCommon/react/renderer/scheduler/SchedulerToolbox.h +++ b/packages/react-native/ReactCommon/react/renderer/scheduler/SchedulerToolbox.h @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include