From 9af98ccd71e7329e3188f1c8fb2a48eed19afaeb Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Tue, 12 Mar 2024 11:17:40 -0700 Subject: [PATCH] Prevent OSS build breakage due to unused-local-typedef (#43449) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43449 Error: ``` react-native/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp:162:5: error: unused typedef 'INVALID_REQUESTED_LOG_SEVERITY' [-Werror,-Wunused-local-typedef] LOG_EVERY_N(INFO, 10) << "instanceHandle is null, event of type " << type ^ react-native/packages/react-native/ReactAndroid/build/third-party-ndk/glog/exported/glog/logging.h:943:30: note: expanded from macro 'LOG_EVERY_N' INVALID_REQUESTED_LOG_SEVERITY); \ ^ 1 error generated. ninja: build stopped: subcommand failed. ``` This has been fixed upstream (https://github.com/google/glog/commit/8b3023f7e4ca46e0ecf5f660dd7340c79139bc34) but we're on an older glog version, so ignore the error. Changelog: [Internal] Reviewed By: fabriziocucci Differential Revision: D54811655 fbshipit-source-id: a00c23528d457ae365b0a27e680bb46afabb152f --- .../ReactCommon/react/renderer/uimanager/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/uimanager/CMakeLists.txt index 8f0aafeb802..badeb64afcf 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/CMakeLists.txt @@ -12,6 +12,7 @@ add_compile_options( -std=c++20 -Wall -Wpedantic + -Wno-unused-local-typedef -DLOG_TAG=\"Fabric\") file(GLOB react_render_uimanager_SRC CONFIGURE_DEPENDS *.cpp)