From 9a5e22650ab02006308f9ecd7430c976353040a3 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Thu, 10 Jun 2021 00:45:12 -0700 Subject: [PATCH] RN project wide Kotlin version (#31645) Summary: This PR sets project wide Kotlin version to 1.4.21, supported in Buck https://github.com/facebook/buck/tree/dev/third-party/java/kotlin. We had to specify version for both kotlin-dsl and kotlin('jvm') plugins to remove version mismatch warnings in **react-native-gradle-plugin**. Also I expect more Kotlin code in RN, so instead of specifying version for each sub-project it's better to have project wide setting. We don't need to load Kotlin in react-native-gradle-plugin because Kotlin is available RN project wide. ## Changelog [Internal] [Changed] - Project wide Kotlin version set to 1.4.21 Pull Request resolved: https://github.com/facebook/react-native/pull/31645 Test Plan: Everything works as expected, no visible change for developers. Reviewed By: yungsters Differential Revision: D28991440 Pulled By: ShikaSD fbshipit-source-id: 971fa6f50c12d916a56d0dcde7c65299496fb68a --- build.gradle.kts | 3 ++- gradle.properties | 1 + packages/react-native-gradle-plugin/build.gradle.kts | 1 - 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index 47d59f05b27..2357d613483 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -12,9 +12,10 @@ buildscript { mavenCentral() } dependencies { + val kotlin_version: String by project classpath("com.android.tools.build:gradle:4.2.1") classpath("de.undercouch:gradle-download-task:4.1.1") - + classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version") // NOTE: Do not place your application dependencies here; they belong // in the individual module build.gradle files } diff --git a/gradle.properties b/gradle.properties index 0edb7925961..94445081b28 100644 --- a/gradle.properties +++ b/gradle.properties @@ -6,3 +6,4 @@ org.gradle.parallel=true ANDROID_NDK_VERSION=20.1.5948944 android.useAndroidX=true +kotlin_version=1.4.21 diff --git a/packages/react-native-gradle-plugin/build.gradle.kts b/packages/react-native-gradle-plugin/build.gradle.kts index baf3afc39d6..e81ff060a6e 100644 --- a/packages/react-native-gradle-plugin/build.gradle.kts +++ b/packages/react-native-gradle-plugin/build.gradle.kts @@ -8,7 +8,6 @@ plugins { `java-gradle-plugin` `kotlin-dsl` - kotlin("jvm") version "1.4.20" } repositories {