From 99153d8ad8164680ff0e7a0130210858d75b1df7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateo=20Guzm=C3=A1n?= Date: Wed, 16 Apr 2025 09:46:00 -0700 Subject: [PATCH] Make `HeadlessJsTaskSupportModule` internal (#50739) Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.modules.core.HeadlessJsTaskSupportModule). ## Changelog: [INTERNAL] - Make com.facebook.react.modules.core.HeadlessJsTaskSupportModule internal Pull Request resolved: https://github.com/facebook/react-native/pull/50739 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cortinico Differential Revision: D73089424 Pulled By: rshest fbshipit-source-id: efad44f89679932ed6bebcf19fb2beeb096881cb --- packages/react-native/ReactAndroid/api/ReactAndroid.api | 6 ------ .../react/modules/core/HeadlessJsTaskSupportModule.kt | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index e95c0a6505d..50d86628883 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -2727,12 +2727,6 @@ public class com/facebook/react/modules/core/ExceptionsManagerModule : com/faceb public final class com/facebook/react/modules/core/ExceptionsManagerModule$Companion { } -public class com/facebook/react/modules/core/HeadlessJsTaskSupportModule : com/facebook/fbreact/specs/NativeHeadlessJsTaskSupportSpec { - public fun (Lcom/facebook/react/bridge/ReactApplicationContext;)V - public fun notifyTaskFinished (D)V - public fun notifyTaskRetry (DLcom/facebook/react/bridge/Promise;)V -} - public abstract interface class com/facebook/react/modules/core/JavaScriptTimerExecutor { public abstract fun callIdleCallbacks (D)V public abstract fun callTimers (Lcom/facebook/react/bridge/WritableArray;)V diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/core/HeadlessJsTaskSupportModule.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/core/HeadlessJsTaskSupportModule.kt index 3bf1e3fa4e7..4d9ec043f97 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/core/HeadlessJsTaskSupportModule.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/core/HeadlessJsTaskSupportModule.kt @@ -19,7 +19,7 @@ import com.facebook.react.module.annotations.ReactModule * it can e.g. release any resources, stop timers etc. */ @ReactModule(name = NativeHeadlessJsTaskSupportSpec.NAME) -public open class HeadlessJsTaskSupportModule(reactContext: ReactApplicationContext?) : +internal open class HeadlessJsTaskSupportModule(reactContext: ReactApplicationContext?) : NativeHeadlessJsTaskSupportSpec(reactContext) { override fun notifyTaskRetry(taskIdDouble: Double, promise: Promise) { val taskId = taskIdDouble.toInt()