Fabric: folly::dynamic was replaced with RawValue in prop-parsing infra

Summary:
Our long-term plan is to completely illuminate `jsi::Value`-to-`folly::dynamic` serialization step in prop parsing process improving performance and memory pressure. At the same time, we don't want to introduce a hard dependency in application code to JSI because it exposes direct access to VM and prevents parsing some data that come *NOT* from JSVM.
RawValue is an extremely light-weight (hopefully fully optimized-out) abstraction that provides limited JSON-like and C++-idiomatic interface.

The current particular implementation is still using `folly::dynamic` inside, but I have fully JSI-powered one which will replace the current one right after we figure out how to deal with folly::dynamic-specific callsites. Or we can implement RawValue in a hybrid manner if a code-size implication of that will be minimal.

Reviewed By: JoshuaGross, mdvacca

Differential Revision: D13962466

fbshipit-source-id: e848522fd242f21e9e771773f2103f1c1d9d7f21
This commit is contained in:
Valentin Shergin authored and Facebook Github Bot committed 2019-02-06 16:34:46 -08:00
1 parent b0c8275369
commit 9842e39019
26 files changed
+660 -319

No files matched your search

@@ -16,8 +16,7 @@
using namespace facebook::react;
TEST(ShadowNodeTest, handleProps) {
RawProps raw;
raw["nativeID"] = "abc";
const auto &raw = RawProps(folly::dynamic::object("nativeID", "abc"));
auto props = std::make_shared<Props>(Props(), raw);