Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove logs related to T62192299

Browse Source 
Summary:
Removing logs related to T62192299 that we don't need anymore.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D21773629

fbshipit-source-id: d16c01f87be3ed7512fe90b6e261b4c7efbd3068
This commit is contained in:
Joshua Gross
2020-05-29 15:48:24 -07:00
committed by Facebook GitHub Bot
parent 92160f3144
commit 983b0a0903
5 changed files with 3 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
+3 -5
View File
@@ -655,9 +655,9 @@ public class ReactInstanceManager {
}
}
/** Temporary: due to T62192299, log sources of destroy calls. TODO T62192299: delete */
/** Temporary: due to T67035147, log sources of destroy calls. TODO T67035147: delete */
private void logOnDestroy() {
FLog.e(
FLog.d(
TAG,
"ReactInstanceManager.destroy called",
new RuntimeException("ReactInstanceManager.destroy called"));
@@ -669,7 +669,6 @@ public class ReactInstanceManager {
UiThreadUtil.assertOnUiThread();
PrinterHolder.getPrinter().logMessage(ReactDebugOverlayTags.RN_CORE, "RNCore: Destroy");
// TODO T62192299: remove when investigation is complete
logOnDestroy();
if (mHasStartedDestroying) {
@@ -1134,8 +1133,7 @@ public class ReactInstanceManager {
}
private void attachRootViewToInstance(final ReactRoot reactRoot) {
// TODO: downgrade back to FLog.d once T62192299 is resolved.
FLog.e(ReactConstants.TAG, "ReactInstanceManager.attachRootViewToInstance()");
FLog.d(ReactConstants.TAG, "ReactInstanceManager.attachRootViewToInstance()");
Systrace.beginSection(TRACE_TAG_REACT_JAVA_BRIDGE, "attachRootViewToInstance");
@Nullable