diff --git a/ReactCommon/fabric/core/propsConversions.h b/ReactCommon/fabric/core/propsConversions.h index c5efbe3d456..350eb017e75 100644 --- a/ReactCommon/fabric/core/propsConversions.h +++ b/ReactCommon/fabric/core/propsConversions.h @@ -22,6 +22,8 @@ inline void fromDynamic(const folly::dynamic &value, int &result) { // So this always converts the value to int64 instead. result = value.asInt(); } +inline void fromDynamic(const folly::dynamic &value, float &result) { result = (float)value.asDouble(); } +inline void fromDynamic(const folly::dynamic &value, double &result) { result = value.asDouble(); } inline void fromDynamic(const folly::dynamic &value, std::string &result) { result = value.getString(); } template diff --git a/ReactCommon/fabric/graphics/conversions.h b/ReactCommon/fabric/graphics/conversions.h index d2adc857c03..3d5cc427528 100644 --- a/ReactCommon/fabric/graphics/conversions.h +++ b/ReactCommon/fabric/graphics/conversions.h @@ -55,10 +55,6 @@ inline std::string toString(const SharedColor &value) { #pragma mark - Geometry -inline void fromDynamic(const folly::dynamic &value, Float &result) { - result = value.asDouble(); -} - inline void fromDynamic(const folly::dynamic &value, Point &result) { if (value.isObject()) { result = Point {(Float)value["x"].asDouble(), (Float)value["y"].asDouble()};