From 97b42bb142f4f9d52af3f85e288ab7742b282fed Mon Sep 17 00:00:00 2001 From: "glevi@fb.com" Date: Fri, 23 Aug 2019 08:04:24 -0700 Subject: [PATCH] Deploy v0.106.0 to xplat/js Reviewed By: mroch Differential Revision: D16979246 fbshipit-source-id: 995fbd391823eaf0c9e3a673cf8fbe061ce0545a --- .flowconfig | 2 +- .flowconfig.android | 2 +- .../ActivityIndicator/ActivityIndicator.js | 4 +++- Libraries/Experimental/WindowedListView.js | 5 ----- Libraries/Sample/Sample.android.js | 4 ++-- Libraries/Text/TextAncestor.js | 3 --- .../NativeAnimation/NativeAnimationsExample.js | 3 --- .../PointerEvents/PointerEventsExample.js | 3 --- .../ProgressViewIOS/ProgressViewIOSExample.js | 3 --- .../ScrollView/ScrollViewSimpleExample.js | 3 --- RNTester/js/examples/Share/ShareExample.js | 3 --- .../examples/TextInput/TextInputExample.ios.js | 18 ------------------ .../src/androidTest/js/ScrollViewTestModule.js | 6 ------ .../hermes/inspector/tools/msggen/src/index.js | 1 - package.json | 2 +- template/_flowconfig | 2 +- yarn.lock | 8 ++++---- 17 files changed, 13 insertions(+), 59 deletions(-) diff --git a/.flowconfig b/.flowconfig index ec2c82e32de..e9022018546 100644 --- a/.flowconfig +++ b/.flowconfig @@ -79,4 +79,4 @@ untyped-import untyped-type-import [version] -^0.105.0 +^0.106.0 diff --git a/.flowconfig.android b/.flowconfig.android index 15f63ee87cb..e0124455848 100644 --- a/.flowconfig.android +++ b/.flowconfig.android @@ -79,4 +79,4 @@ untyped-import untyped-type-import [version] -^0.105.0 +^0.106.0 diff --git a/Libraries/Components/ActivityIndicator/ActivityIndicator.js b/Libraries/Components/ActivityIndicator/ActivityIndicator.js index 2eed90d8de1..877ce50d502 100644 --- a/Libraries/Components/ActivityIndicator/ActivityIndicator.js +++ b/Libraries/Components/ActivityIndicator/ActivityIndicator.js @@ -109,7 +109,9 @@ const ActivityIndicator = (props: Props, forwardedRef?: any) => { // $FlowFixMe Flow doesn't know when this is the android component ) : ( - // $FlowFixMe Flow doesn't know when this is the iOS component + /* $FlowFixMe(>=0.106.0 site=react_native_android_fb) This comment + * suppresses an error found when Flow v0.106 was deployed. To see the + * error, delete this comment and run Flow. */ )} diff --git a/Libraries/Experimental/WindowedListView.js b/Libraries/Experimental/WindowedListView.js index 84ff57dc65c..ec56b388ed1 100644 --- a/Libraries/Experimental/WindowedListView.js +++ b/Libraries/Experimental/WindowedListView.js @@ -183,11 +183,6 @@ class WindowedListView extends React.Component { maxNumToRender: 30, numToRenderAhead: 10, viewablePercentThreshold: 50, - /* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an - * error caught by Flow 0.59 which was not caught before. Most likely, this - * error is because an exported function parameter is missing an - * annotation. Without an annotation, these parameters are uncovered by - * Flow. */ renderScrollComponent: props => , disableIncrementalRendering: false, recomputeRowsBatchingPeriod: 10, // This should capture most events that happen within a frame diff --git a/Libraries/Sample/Sample.android.js b/Libraries/Sample/Sample.android.js index 65ab87d6b04..6020b60b183 100644 --- a/Libraries/Sample/Sample.android.js +++ b/Libraries/Sample/Sample.android.js @@ -16,8 +16,8 @@ const warning = require('fbjs/lib/warning'); const Sample = { test: function() { - /* $FlowFixMe(>=0.103.0 site=react_native_android_fb) This comment - * suppresses an error found when Flow v0.103 was deployed. To see the + /* $FlowFixMe(>=0.106.0 site=react_native_android_fb) This comment + * suppresses an error found when Flow v0.106 was deployed. To see the * error, delete this comment and run Flow. */ warning('Not yet implemented for Android.'); }, diff --git a/Libraries/Text/TextAncestor.js b/Libraries/Text/TextAncestor.js index 24fb1b45512..b791319c80c 100644 --- a/Libraries/Text/TextAncestor.js +++ b/Libraries/Text/TextAncestor.js @@ -15,7 +15,4 @@ const React = require('react'); /** * Whether the current element is the descendant of a element. */ -/* $FlowFixMe(>=0.85.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.85 was deployed. To see the error, delete this comment - * and run Flow. */ module.exports = (React.createContext(false): React$Context<$FlowFixMe>); diff --git a/RNTester/js/examples/NativeAnimation/NativeAnimationsExample.js b/RNTester/js/examples/NativeAnimation/NativeAnimationsExample.js index f654aa4ca97..01b6b077294 100644 --- a/RNTester/js/examples/NativeAnimation/NativeAnimationsExample.js +++ b/RNTester/js/examples/NativeAnimation/NativeAnimationsExample.js @@ -309,9 +309,6 @@ class TrackingExample extends React.Component< this.state.toJS.setValue(nextValue); }; - /* $FlowFixMe(>=0.85.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.85 was deployed. To see the error, delete this comment - * and run Flow. */ renderBlock = (anim, dest) => [ =0.70.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.70 was deployed. To see the error delete this comment - * and run Flow. */ exports.examples = (exampleClasses.map(infoToExample): Array); diff --git a/RNTester/js/examples/ProgressViewIOS/ProgressViewIOSExample.js b/RNTester/js/examples/ProgressViewIOS/ProgressViewIOSExample.js index e2c729cfbfd..5f700308178 100644 --- a/RNTester/js/examples/ProgressViewIOS/ProgressViewIOSExample.js +++ b/RNTester/js/examples/ProgressViewIOS/ProgressViewIOSExample.js @@ -42,9 +42,6 @@ class ProgressViewExample extends React.Component { this._rafId = requestAnimationFrame(() => this.updateProgress()); }; - /* $FlowFixMe(>=0.85.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.85 was deployed. To see the error, delete this comment - * and run Flow. */ getProgress = offset => { const progress = this.state.progress + offset; return Math.sin(progress % Math.PI) % 1; diff --git a/RNTester/js/examples/ScrollView/ScrollViewSimpleExample.js b/RNTester/js/examples/ScrollView/ScrollViewSimpleExample.js index 5487fa866cc..0409560c04d 100644 --- a/RNTester/js/examples/ScrollView/ScrollViewSimpleExample.js +++ b/RNTester/js/examples/ScrollView/ScrollViewSimpleExample.js @@ -22,9 +22,6 @@ const { const NUM_ITEMS = 20; class ScrollViewSimpleExample extends React.Component<{}> { - /* $FlowFixMe(>=0.98.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.98 was deployed. To see the error delete this comment - * and run Flow. */ makeItems: (nItems: number, styles: any) => Array = ( nItems: number, styles, diff --git a/RNTester/js/examples/Share/ShareExample.js b/RNTester/js/examples/Share/ShareExample.js index 0d4bf3b6f0a..fe33658a9f2 100644 --- a/RNTester/js/examples/Share/ShareExample.js +++ b/RNTester/js/examples/Share/ShareExample.js @@ -28,9 +28,6 @@ class ShareMessageExample extends React.Component { _shareText: Function; _showResult: Function; - /* $FlowFixMe(>=0.85.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.85 was deployed. To see the error, delete this comment - * and run Flow. */ constructor(props) { super(props); diff --git a/RNTester/js/examples/TextInput/TextInputExample.ios.js b/RNTester/js/examples/TextInput/TextInputExample.ios.js index f21ca72d32c..f38b65ebdd8 100644 --- a/RNTester/js/examples/TextInput/TextInputExample.ios.js +++ b/RNTester/js/examples/TextInput/TextInputExample.ios.js @@ -100,9 +100,6 @@ class TextEventsExample extends React.Component<{}, $FlowFixMeState> { } class TextInputAccessoryViewExample extends React.Component<{}, *> { - /* $FlowFixMe(>=0.85.0 site=react_native_ios_fb) This comment suppresses an - * error found when Flow v0.85 was deployed. To see the error, delete this - * comment and run Flow. */ constructor(props) { super(props); this.state = {text: 'Placeholder Text'}; @@ -132,9 +129,6 @@ class TextInputAccessoryViewExample extends React.Component<{}, *> { } class RewriteExample extends React.Component<$FlowFixMeProps, any> { - /* $FlowFixMe(>=0.85.0 site=react_native_ios_fb) This comment suppresses an - * error found when Flow v0.85 was deployed. To see the error, delete this - * comment and run Flow. */ constructor(props) { super(props); this.state = {text: ''}; @@ -167,9 +161,6 @@ class RewriteExampleInvalidCharacters extends React.Component< $FlowFixMeProps, any, > { - /* $FlowFixMe(>=0.85.0 site=react_native_ios_fb) This comment suppresses an - * error found when Flow v0.85 was deployed. To see the error, delete this - * comment and run Flow. */ constructor(props) { super(props); this.state = {text: ''}; @@ -191,9 +182,6 @@ class RewriteExampleInvalidCharacters extends React.Component< } class RewriteExampleKana extends React.Component<$FlowFixMeProps, any> { - /* $FlowFixMe(>=0.85.0 site=react_native_ios_fb) This comment suppresses an - * error found when Flow v0.85 was deployed. To see the error, delete this - * comment and run Flow. */ constructor(props) { super(props); this.state = {text: ''}; @@ -215,9 +203,6 @@ class RewriteExampleKana extends React.Component<$FlowFixMeProps, any> { } class SecureEntryExample extends React.Component<$FlowFixMeProps, any> { - /* $FlowFixMe(>=0.85.0 site=react_native_ios_fb) This comment suppresses an - * error found when Flow v0.85 was deployed. To see the error, delete this - * comment and run Flow. */ constructor(props) { super(props); this.state = { @@ -263,9 +248,6 @@ class SecureEntryExample extends React.Component<$FlowFixMeProps, any> { } class TokenizedTextExample extends React.Component<$FlowFixMeProps, any> { - /* $FlowFixMe(>=0.85.0 site=react_native_ios_fb) This comment suppresses an - * error found when Flow v0.85 was deployed. To see the error, delete this - * comment and run Flow. */ constructor(props) { super(props); this.state = {text: 'Hello #World'}; diff --git a/ReactAndroid/src/androidTest/js/ScrollViewTestModule.js b/ReactAndroid/src/androidTest/js/ScrollViewTestModule.js index d98f64ef73d..3a6a887919b 100644 --- a/ReactAndroid/src/androidTest/js/ScrollViewTestModule.js +++ b/ReactAndroid/src/androidTest/js/ScrollViewTestModule.js @@ -92,9 +92,6 @@ type State = {| |}; class ScrollViewTestApp extends React.Component { - /* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.87 was deployed. To see the error, delete this comment - * and run Flow. */ scrollView: {|current: any | null|} = React.createRef(); state: State = getInitialState(); @@ -129,9 +126,6 @@ class ScrollViewTestApp extends React.Component { } class HorizontalScrollViewTestApp extends React.Component { - /* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an error - * found when Flow v0.87 was deployed. To see the error, delete this comment - * and run Flow. */ scrollView: {|current: any | null|} = React.createRef(); state: State = getInitialState(); diff --git a/ReactCommon/hermes/inspector/tools/msggen/src/index.js b/ReactCommon/hermes/inspector/tools/msggen/src/index.js index a0955329d7f..5f1296f1218 100644 --- a/ReactCommon/hermes/inspector/tools/msggen/src/index.js +++ b/ReactCommon/hermes/inspector/tools/msggen/src/index.js @@ -11,7 +11,6 @@ import fs from 'fs'; -// $FlowFixMe: flow doesn't know about yargs import yargs from 'yargs'; import {Command} from './Command'; diff --git a/package.json b/package.json index f96e75c0c99..64ed5ae7fdb 100644 --- a/package.json +++ b/package.json @@ -138,7 +138,7 @@ "eslint-plugin-react-hooks": "^2.0.1", "eslint-plugin-react-native": "3.6.0", "eslint-plugin-relay": "1.3.0", - "flow-bin": "^0.105.0", + "flow-bin": "^0.106.0", "flow-remove-types": "1.2.3", "jest": "^24.8.0", "jest-junit": "^6.3.0", diff --git a/template/_flowconfig b/template/_flowconfig index ae78e6a1a93..3759e18699a 100644 --- a/template/_flowconfig +++ b/template/_flowconfig @@ -72,4 +72,4 @@ untyped-import untyped-type-import [version] -^0.105.0 +^0.106.0 diff --git a/yarn.lock b/yarn.lock index 5341dc1fee9..b930749fc87 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3159,10 +3159,10 @@ flat-cache@^1.2.1: rimraf "~2.6.2" write "^0.2.1" -flow-bin@^0.105.0: - version "0.105.1" - resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.105.1.tgz#5ce4515b583e5fa6ea1b82bc849c354271f5b88d" - integrity sha512-wRI5ogu/+85fgftljAOtnDBx9+2JHToyq2XifzoMmXc5mmB9OE7osukzwi2PuOoEKtq9fu+APRD+MqbEJ8bUwQ== +flow-bin@^0.106.0: + version "0.106.0" + resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.106.0.tgz#55aab8c154df2bd78abfe6acfe120cf5638a0352" + integrity sha512-sV8lNBLTTfieUBNvQZFc1K1wXjC8I+O7ltv6G/nd3hdGyq2Jymyy01zAPhJ7MRw8yZ0X2dBSHFZx5DPreBqhAg== flow-parser@0.*: version "0.89.0"