From 973198667d7bbbf3b5d8890fc0a53dc99d0bce18 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 30 Jul 2020 17:06:54 -0700 Subject: [PATCH] Upgrade react-native-github Android to support API level 19+ Summary: This diff upgrades react-native-github Android to support API level 19+ changelog: [Android][Deprecated] Deprecate support of Android API levels 16 to 18. The new minSDK version will be 19+ moving forward Reviewed By: JoshuaGross Differential Revision: D22734208 fbshipit-source-id: b052721c8cfb44f8d74cf4bbb5b7a769e544d1d9 --- RNTester/android/app/build.gradle | 2 +- ReactAndroid/build.gradle | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/RNTester/android/app/build.gradle b/RNTester/android/app/build.gradle index 0a36475ade5..77700609599 100644 --- a/RNTester/android/app/build.gradle +++ b/RNTester/android/app/build.gradle @@ -121,7 +121,7 @@ android { defaultConfig { applicationId "com.facebook.react.uiapp" - minSdkVersion 18 + minSdkVersion 19 targetSdkVersion 29 versionCode 1 versionName "1.0" diff --git a/ReactAndroid/build.gradle b/ReactAndroid/build.gradle index 23d9fd5912b..c2a172a72a4 100644 --- a/ReactAndroid/build.gradle +++ b/ReactAndroid/build.gradle @@ -166,7 +166,7 @@ task prepareJSC { def jscPackagePath = findNodeModulePath(projectDir, "jsc-android") if (!jscPackagePath) { throw new GradleScriptException("Could not find the jsc-android npm package", null) - } + } def jscDist = file("$jscPackagePath/dist") if (!jscDist.exists()) { @@ -223,7 +223,7 @@ task downloadNdkBuildDependencies { def findNodeModulePath(baseDir, packageName) { def basePath = baseDir.toPath().normalize() // Node's module resolution algorithm searches up to the root directory, - // after which the base path will be null + // after which the base path will be null while (basePath) { def candidatePath = Paths.get(basePath.toString(), "node_modules", packageName) if (candidatePath.toFile().exists()) { @@ -382,7 +382,7 @@ android { } defaultConfig { - minSdkVersion(16) + minSdkVersion(19) targetSdkVersion(28) versionCode(1) versionName("1.0")