Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor RCTPerformanceLogger to avoid having global state

Browse Source 
Reviewed By: javache

Differential Revision: D3509004

fbshipit-source-id: c4ab12b3f1defa32c2b1c211e775f6782ede4b7f
This commit is contained in:
Alexey Lang
2016-07-07 07:29:57 -07:00
committed by Facebook Github Bot 4
parent 4f5c2b48fe
commit 97299260b6
12 changed files with 206 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Base/RCTJavaScriptLoader.m
+7 -9
View File
@@ -35,7 +35,7 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
NSError *error = [NSError errorWithDomain:@"JavaScriptLoader" code:1 userInfo:@{
NSLocalizedDescriptionKey: errorDescription
}];
onComplete(error, nil);
onComplete(error, nil, 0);
return;
}
@@ -51,14 +51,14 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
// modules into JSC as they're required.
FILE *bundle = fopen(scriptURL.path.UTF8String, "r");
if (!bundle) {
onComplete(RCTErrorWithMessage([NSString stringWithFormat:@"Error opening bundle %@", scriptURL.path]), source);
onComplete(RCTErrorWithMessage([NSString stringWithFormat:@"Error opening bundle %@", scriptURL.path]), source, 0);
return;
}
uint32_t magicNumber;
if (fread(&magicNumber, sizeof(magicNumber), 1, bundle) != 1) {
fclose(bundle);
onComplete(RCTErrorWithMessage(@"Error reading bundle"), source);
onComplete(RCTErrorWithMessage(@"Error reading bundle"), source, 0);
return;
}
@@ -81,9 +81,8 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
sourceLength = source.length;
}
RCTPerformanceLoggerSet(RCTPLBundleSize, sourceLength);
fclose(bundle);
onComplete(error, source);
onComplete(error, source, sourceLength);
});
return;
}
@@ -105,7 +104,7 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
code:error.code
userInfo:userInfo];
}
onComplete(error, nil);
onComplete(error, nil, 0);
return;
}
@@ -143,11 +142,10 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
code:((NSHTTPURLResponse *)response).statusCode
userInfo:userInfo];
onComplete(error, nil);
onComplete(error, nil, 0);
return;
}
RCTPerformanceLoggerSet(RCTPLBundleSize, data.length);
onComplete(nil, data);
onComplete(nil, data, data.length);
}];
[task resume];