From 9700540bec67d221f72fd1d17e918538ffca7a8a Mon Sep 17 00:00:00 2001 From: Dmitry Rykun Date: Thu, 14 Mar 2024 11:10:54 -0700 Subject: [PATCH] Bring back the UNSET constant to TextAttributeProps (#43491) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43491 This diff brings back the `UNSET` constant to `TextAttributeProps`. The removal of this constant was an unnecessary breaking change, that has broken several third-party libraries. Changelog: [Android][Fixed] - Bring back the UNSET constant to TextAttributeProps. Reviewed By: fabriziocucci Differential Revision: D54899524 fbshipit-source-id: 368bde77d43f310fd458537d0191d09174fa5167 --- packages/react-native/ReactAndroid/api/ReactAndroid.api | 1 + .../java/com/facebook/react/views/text/TextAttributeProps.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index d43f2379183..cb71470eead 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -7083,6 +7083,7 @@ public class com/facebook/react/views/text/TextAttributeProps : com/facebook/rea public static final field TA_KEY_TEXT_SHADOW_OFFSET_DY S public static final field TA_KEY_TEXT_SHADOW_RADIUS S public static final field TA_KEY_TEXT_TRANSFORM S + public static final field UNSET I protected field mAccessibilityRole Lcom/facebook/react/uimanager/ReactAccessibilityDelegate$AccessibilityRole; protected field mAllowFontScaling Z protected field mBackgroundColor I diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.java index 25791e00679..202734f3795 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.java @@ -62,6 +62,8 @@ public class TextAttributeProps implements EffectiveTextAttributeProvider { public static final short TA_KEY_ROLE = 26; public static final short TA_KEY_TEXT_TRANSFORM = 27; + public static final int UNSET = -1; + private static final String PROP_SHADOW_OFFSET = "textShadowOffset"; private static final String PROP_SHADOW_OFFSET_WIDTH = "width"; private static final String PROP_SHADOW_OFFSET_HEIGHT = "height";