mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Persist Hermes MacOS Artifacts to Workspace Depending on Build Flavor (#39234)
Summary: In some occasion, we have a race condition when: - prepare hermes workspace has some artifacts but not all of them, and it store them to the workspace - the pipeline rebuilds the missing artifacts - the build_hermes_macos jobs tries to upload the pre-existing artifacts, uploading the whole folder. So, for example, imagine that at the prepare_hermes_workspace time, we are able to restore both the `hermes-ios-release.tar.gz` and the `hermes-ios-debug.tar.gz`. When the two concurrent `build_hermes_MacOS-Debug` and `build_hermes_MacOS-Release`, they will both try to upload both tars at the same time, and that results in the concurrent errors we are seeing. This change should fix this, by having the Debug job upload the Debug artifacts only and the Release jobs upload the Release artifacts only, so there will be no concurrent upload of the same files. ## Changelog: [Internal] - Upload Hermes macos artifacts depending on the Build flavor. Pull Request resolved: https://github.com/facebook/react-native/pull/39234 Test Plan: CircleCI stays green. Reviewed By: GijsWeterings Differential Revision: D48861430 Pulled By: cipolleschi fbshipit-source-id: 02bd045cdb969ad1c173e78ffb42185c14ba171e
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ce32d07ed9
commit
9552ed0ffc
@@ -1124,12 +1124,27 @@ jobs:
|
||||
paths: /tmp/hermes/dSYM/Release
|
||||
- store_hermes_apple_artifacts:
|
||||
flavor: << parameters.flavor >>
|
||||
- when:
|
||||
condition:
|
||||
equal: [ << parameters.flavor >>, "Release" ]
|
||||
steps:
|
||||
- persist_to_workspace:
|
||||
root: /tmp/hermes/
|
||||
paths:
|
||||
- hermes-runtime-darwin/hermes-ios-release.tar.gz
|
||||
- when:
|
||||
condition:
|
||||
equal: [ << parameters.flavor >>, "Debug" ]
|
||||
steps:
|
||||
- persist_to_workspace:
|
||||
root: /tmp/hermes/
|
||||
paths:
|
||||
- hermes-runtime-darwin/hermes-ios-debug.tar.gz
|
||||
- persist_to_workspace:
|
||||
root: /tmp/hermes/
|
||||
paths:
|
||||
- hermes-runtime-darwin
|
||||
- osx-bin
|
||||
- dSYM
|
||||
- osx-bin/<< parameters.flavor >>
|
||||
- dSYM/<< parameters.flavor >>
|
||||
|
||||
build_hermesc_windows:
|
||||
executor:
|
||||
|
||||
Reference in New Issue
Block a user