Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the escape hatch

Browse Source 
Summary: I originally added `forceFullRefresh` as an escape hatch in case Fast Refresh is too unreliable. In practice we haven't seen any major issues with it. Since this option is already very obscure, I'm just removing it.

Reviewed By: shergin

Differential Revision: D16286632

fbshipit-source-id: c3dc44cffd459912e194e273acf868f3380c64cc
This commit is contained in:
Dan Abramov
2019-07-17 06:29:25 -07:00
committed by Facebook Github Bot
parent 8e6f2f289b
commit 93aab84699
4 changed files with 2 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java
-10
View File
@@ -507,19 +507,9 @@ public class DevSupportManagerImpl
mReactInstanceManagerHelper.toggleElementInspector();
}
});
// "Live reload" which refreshes on every edit was removed in favor of "Fast Refresh".
// While native code for "Live reload" is still there, please don't add the option back.
//
// If for some reason you really need a full reload on every edit,
// you can put this into your application entry point as an escape hatch:
//
// if (__DEV__) {
// require.Refresh.forceFullRefresh = true;
// }
//
// See D15958697 for more context.
options.put(
mDevSettings.isHotModuleReplacementEnabled()
? mApplicationContext.getString(R.string.catalyst_hot_reloading_stop)