From 92dca5370239f2c9881455b683ff384e2187430f Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Wed, 31 Jul 2024 22:32:23 -0700 Subject: [PATCH] Add borderStartWidth and borderEndWidth support (#45854) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45854 Right now these border widths are incorporated into Yoga layout, but view manager never responds to it. This adds the props supported by to text, still missing many others. The underlying functions are aware of the spacing type, I plan to fix this more thoroughly, across the different edges, properties, and different components, after we remove the legacy background stack, and all of these can live in a single place on BaseViewManager. Changelog: [Android][Fixed] - Add borderStartWidth and borderEndWidth support Reviewed By: necolas Differential Revision: D60560343 fbshipit-source-id: 8e1ebaa087e0728b5758850239c41aeae5d619a9 --- .../react/views/text/ReactTextAnchorViewManager.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java index c170edac53a..332e983bc0e 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java @@ -37,7 +37,13 @@ public abstract class ReactTextAnchorViewManager { private static final int[] SPACING_TYPES = { - Spacing.ALL, Spacing.LEFT, Spacing.RIGHT, Spacing.TOP, Spacing.BOTTOM, + Spacing.ALL, + Spacing.LEFT, + Spacing.RIGHT, + Spacing.TOP, + Spacing.BOTTOM, + Spacing.START, + Spacing.END }; private static final String TAG = "ReactTextAnchorViewManager"; @@ -161,6 +167,8 @@ public abstract class ReactTextAnchorViewManager