mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Add guards around nativeProps usage to prevent race conditions (#52646)
Summary: Some third-party libraries, like react-native-reanimated, can clone nodes in a different thread while react-native is calling `setNativeProps_DEPRECATED`. This results in a race condition, where a stale pointer to `nativeProps_DEPRECATED` can be accessed, resulting in a crash. This usually manifests as a `EXC_BAD_ACCESS` crash on iOS. On Android it seems more rare. We've added a lock around accesses to nativeProps_DEPRECATED, but alternative options of fixing this can be considered too. For more information see https://github.com/software-mansion/react-native-reanimated/issues/7666 ## Changelog: [INTERNAL] [FIXED] - Fixed crashes caused by race conditions when third-party libraries clone the shadow dom from a different thread Pull Request resolved: https://github.com/react/react-native/pull/52646 Test Plan: Due to this being a race condition that only manifests in rare circumstances, it's very difficult to create a reliable reproduction case. The issue mentioned above contains ThreadSanitizer logs that demonstrate this issue. TSan no longer complains with this patch applied, and we've not seen any additional issues from it after deploying it in production over the past week. Added unit test covering the `nativeProps_DEPRECATED` merge logic in `UIManager::cloneNode` and `ShadowNode::clone`: ``` buck2 test //xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/uimanager:tests -- --regex FabricUIManagerTest ``` Reviewed By: zeyap Differential Revision: D110169424 Pulled By: javache fbshipit-source-id: 6139253dcc2c33348a0c1a3bd01e695d15aa83bc
This commit is contained in:
1 parent
d1c5ee0388
commit
923e7ddcaf
13 files changed
+239
-74
No files matched your search
@@ -4660,6 +4660,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -4474,6 +4474,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -4651,6 +4651,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -6861,6 +6861,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -6703,6 +6703,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -6852,6 +6852,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -3214,6 +3214,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -3068,6 +3068,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
@@ -3205,6 +3205,7 @@ class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
public facebook::react::SharedEventEmitter getEventEmitter() const;
|
||||
public facebook::react::SurfaceId getSurfaceId() const;
|
||||
public facebook::react::Tag getTag() const;
|
||||
public mutable std::mutex nativePropsMutex;
|
||||
public std::shared_ptr<const facebook::react::State> getMostRecentState() const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public using Shared = std::shared_ptr<facebook::react::ShadowNodeFamily>;
|
||||
|
||||
Reference in new issue
Block a user