From 91add1e4e0222c6ccfe33b4f78f0a4d0d7dd02da Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Thu, 23 Jan 2025 16:19:48 -0800 Subject: [PATCH] Remove redundant check in CSSRatio (#48842) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48842 This is a result of inlining isinf previously but we can never be negative infinity because we can never be less than zero. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68474836 fbshipit-source-id: bfce78c4bd269ff2afac99c03250ede676ee1029 --- .../react-native/ReactCommon/react/renderer/css/CSSRatio.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/css/CSSRatio.h b/packages/react-native/ReactCommon/react/renderer/css/CSSRatio.h index 29940a9ddae..8bd5f57e6b3 100644 --- a/packages/react-native/ReactCommon/react/renderer/css/CSSRatio.h +++ b/packages/react-native/ReactCommon/react/renderer/css/CSSRatio.h @@ -54,8 +54,7 @@ struct CSSDataTypeParser { // If either number in the is 0 or infinite, it represents a // degenerate ratio (and, generally, won’t do anything). // https://www.w3.org/TR/css-values-4/#ratios - return value > 0.0f && value != +std::numeric_limits::infinity() && - value != -std::numeric_limits::infinity(); + return value > 0.0f && value != +std::numeric_limits::infinity(); } };